Bug 99713 - MediaStream API: Do some cleanup in the chromium WebKit API
Summary: MediaStream API: Do some cleanup in the chromium WebKit API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Tommy Widenflycht
URL:
Keywords:
Depends on:
Blocks: 56459
  Show dependency tree / graph
 
Reported: 2012-10-18 06:15 PDT by Tommy Widenflycht
Modified: 2012-10-19 00:33 PDT (History)
8 users (show)

See Also:

Attachments
Patch (4.98 KB, patch)
2012-10-18 06:26 PDT, Tommy Widenflycht 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tommy Widenflycht 2012-10-18 06:15:43 PDT 
1) Remove the deprecated version of WebMediaStreamDescriptor::initialize
2) Remove a deprecated constant from WebPeerConnection00HandlerClient
3) Make the two constructSDP functions in WebMediaStreamCenter optional to override. This is part of the preparation to remove PeerConnection00.
Comment 1 Tommy Widenflycht 2012-10-18 06:26:42 PDT 
Created attachment 169403 [details]
Patch
Comment 2 WebKit Review Bot 2012-10-18 06:30:03 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Tommy Widenflycht 2012-10-18 06:32:18 PDT 
Turns out point two could not yet be removed.
Comment 4 Adam Barth 2012-10-18 14:54:03 PDT 
Can we remove webkitPeerConnection00 ?
Comment 5 WebKit Review Bot 2012-10-18 15:08:38 PDT 
Comment on attachment 169403 [details]
Patch

Clearing flags on attachment: 169403

Committed r131814: <http://trac.webkit.org/changeset/131814>
Comment 6 WebKit Review Bot 2012-10-18 15:08:41 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Tommy Widenflycht 2012-10-19 00:33:22 PDT 
(In reply to comment #4)
> Can we remove webkitPeerConnection00 ?

Soon, very soon. It won't be in M24 stable for sure.