Bug 99707 - [CSS Regions] broken feature detection: body.webkitRegionOverset and body.webkitGetRegionFlowRanges shouldn't succeed when disabled at runtime
Summary: [CSS Regions] broken feature detection: body.webkitRegionOverset and body.web...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mihai Maerean
URL:
Keywords: AdobeTracked
Depends on:
Blocks: 57312
  Show dependency tree / graph
 
Reported: 2012-10-18 04:39 PDT by Mihai Maerean
Modified: 2014-04-24 16:45 PDT (History)
9 users (show)

See Also:

Attachments
1st patch (9.55 KB, patch)
2012-12-14 16:49 PST, Mihai Maerean 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mihai Maerean 2012-10-18 04:39:05 PDT 
Steps to reproduce:
disable experimental WebKit features (in about://flags/).
access document.body.webkitRegionOverset and document.body.webkitGetRegionFlowRanges from JavaScript.

Expected result:
an exception should occur because the function should not exist.

Actual result:
the call is successful.
Comment 1 Mihai Maerean 2012-12-14 16:49:02 PST 
Created attachment 179559 [details]
1st patch
Comment 2 WebKit Review Bot 2012-12-16 02:02:13 PST 
Comment on attachment 179559 [details]
1st patch

Clearing flags on attachment: 179559

Committed r137835: <http://trac.webkit.org/changeset/137835>
Comment 3 WebKit Review Bot 2012-12-16 02:02:18 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Kentaro Hara 2012-12-16 15:37:04 PST 
Sorry for the delayed comment. Looks good to me too.
Comment 5 Darin Adler 2014-04-24 16:45:55 PDT 
Moving all JavaScriptGlue bugs to JavaScriptCore. The JavaScriptGlue framework itself is long gone. And most of the more recent bugs put in this component were put there by people who thought this was for some other aspect of “JavaScript glue” and have nothing to do with the actual original reason for the existence of this component, which was an OS-X-only framework named JavaScriptGlue.