RESOLVED FIXED Bug 99704
Add Localizer::monthFormat and implementations 
https://bugs.webkit.org/show_bug.cgi?id=99704
Summary Add Localizer::monthFormat and implementations
Kent Tamura
Reported 2012-10-18 03:35:08 PDT
Localizer::monthFormat will be used for input[type=month].
Attachments
Patch (13.59 KB, patch)
2012-10-18 03:59 PDT, Kent Tamura 		haraken: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2012-10-18 03:59:59 PDT
Created attachment 169388 [details] Patch
Kentaro Hara
Comment 2 2012-10-18 06:43:09 PDT
Comment on attachment 169388 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169388&action=review > Source/WebCore/platform/text/LocaleWin.cpp:720 > + m_monthFormat = convertWindowsDateFormatToLDML(parseDateFormat(getLocaleInfoString(LOCALE_SYEARMONTH))); (I don't know the details but) don't you need to use m_locale instead of LOCALE_SYEARMONTH? > Source/WebKit/chromium/tests/LocaleMacTest.cpp:247 > + EXPECT_STREQ("MMM yyyy", monthFormat("en_US").utf8().data()); Nit: Shall we add a test case for French, just like other tests?
Kent Tamura
Comment 3 2012-10-18 07:29:17 PDT
Comment on attachment 169388 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169388&action=review >> Source/WebCore/platform/text/LocaleWin.cpp:720 >> + m_monthFormat = convertWindowsDateFormatToLDML(parseDateFormat(getLocaleInfoString(LOCALE_SYEARMONTH))); > > (I don't know the details but) don't you need to use m_locale instead of LOCALE_SYEARMONTH? getLocaleInfoString() refers to m_lcid. >> Source/WebKit/chromium/tests/LocaleMacTest.cpp:247 >> + EXPECT_STREQ("MMM yyyy", monthFormat("en_US").utf8().data()); > > Nit: Shall we add a test case for French, just like other tests? will do.
Kent Tamura
Comment 4 2012-10-18 07:32:22 PDT
Committed r131749: <http://trac.webkit.org/changeset/131749>
Note You need to log in before you can comment on or make changes to this bug.