RESOLVED INVALID 99687
Source/WebCore/bindings/js/JSInspectorFrontendHostCustom.cpp misuses PLATFORM(MAC) 
https://bugs.webkit.org/show_bug.cgi?id=99687
Summary Source/WebCore/bindings/js/JSInspectorFrontendHostCustom.cpp misuses PLATFORM...
Jeremy Huddleston Sequoia
Reported 2012-10-17 22:56:31 PDT
Source/WebCore/bindings/js/JSInspectorFrontendHostCustom.cpp returns "mac" for SValue JSInspectorFrontendHost::platform(ExecState* execState), but it should return "darwin" for OS(DARWIN) to be consistent. Similarly, JSInspectorFrontendHost::port should probably return "appkit" or "uikit" for PLATFORM(MAC_OS_X) or PLATFORM(IOS).
Attachments
Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2012-10-19 03:16:29 PDT
Feel free to change. You will need to fix up some js files in WebCore/inspector/front-end too that use "mac".
Jeremy Huddleston Sequoia
Comment 2 2012-10-19 10:17:10 PDT
Ok, thanks I will. Feel free to assign this to me as I don't have that level of bugzilla access.
Note You need to log in before you can comment on or make changes to this bug.