Bug 99687 - Source/WebCore/bindings/js/JSInspectorFrontendHostCustom.cpp misuses PLATFORM(MAC)
Summary: Source/WebCore/bindings/js/JSInspectorFrontendHostCustom.cpp misuses PLATFORM...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jeremy Huddleston Sequoia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-17 22:56 PDT by Jeremy Huddleston Sequoia
Modified: 2014-12-13 15:34 PST (History)
11 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Huddleston Sequoia 2012-10-17 22:56:31 PDT 
Source/WebCore/bindings/js/JSInspectorFrontendHostCustom.cpp returns "mac" for SValue JSInspectorFrontendHost::platform(ExecState* execState), but it should return "darwin" for OS(DARWIN) to be consistent.  Similarly, JSInspectorFrontendHost::port should probably return "appkit" or "uikit" for PLATFORM(MAC_OS_X) or PLATFORM(IOS).
Comment 1 Timothy Hatcher 2012-10-19 03:16:29 PDT 
Feel free to change. You will need to fix up some js files in WebCore/inspector/front-end too that use "mac".
Comment 2 Jeremy Huddleston Sequoia 2012-10-19 10:17:10 PDT 
Ok, thanks I will.  Feel free to assign this to me as I don't have that level of bugzilla access.