WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
99681
[EFL][WK2] Move ewk_{init,shutdown}() to the main() function of EFL API test.
https://bugs.webkit.org/show_bug.cgi?id=99681
Summary
[EFL][WK2] Move ewk_{init,shutdown}() to the main() function of EFL API test.
Eunmi Lee
Reported
2012-10-17 21:57:32 PDT
The ewk_{init,shutdown} is called whenever processing the each test (i.e. creating and deleting ewk_view), so tests can be failed if EFL libraries functions are called between ewk_shutdown() and next ewk_init(). In the current codes, initializing and shutdown are done in the RunLoop() and RunLoop() is created only one time during testing, so there is no problem. However, the problem appears when we move initializing and shutdown of EFL libraries to the ewk_{init, shutdown}() by
https://bugs.webkit.org/show_bug.cgi?id=97173
. The initializing and shutdown codes have to be in the ewk_{init,shutdown} not RunLoop(). So, I fix the EFL API test codes firstly to prevent before failing tests by
https://bugs.webkit.org/show_bug.cgi?id=97173
.
Attachments
Patch
(2.78 KB, patch)
2012-10-18 03:29 PDT
,
Eunmi Lee
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eunmi Lee
Comment 1
2012-10-18 03:29:27 PDT
Created
attachment 169384
[details]
Patch
Gyuyoung Kim
Comment 2
2012-10-18 19:41:04 PDT
Comment on
attachment 169384
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=169384&action=review
> Source/WebKit2/ChangeLog:9 > + so tests can be failed if EFL libraries APIs are called between
Is it possible EFL API is called between ewk_shutdown and next ewk_init ?
Eunmi Lee
Comment 3
2012-10-18 19:46:48 PDT
(In reply to
comment #2
)
> (From update of
attachment 169384
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=169384&action=review
> > > Source/WebKit2/ChangeLog:9 > > + so tests can be failed if EFL libraries APIs are called between > > Is it possible EFL API is called between ewk_shutdown and next ewk_init ?
Sure, that is the problem of API tests. The ecore_pipe_write() can be called to send/receive between ui process and web process, and ecore_timer APIs can be called to test with url loading. They are failed with
Bug 97173
because RunLoop does not cover their fault anymore.
Gyuyoung Kim
Comment 4
2012-10-18 19:53:26 PDT
Comment on
attachment 169384
[details]
Patch Looks make sense. Please landing this after verifying there is no problem in both release and debug API test.
Ryuan Choi
Comment 5
2012-10-18 21:12:31 PDT
Committed
r131851
: <
http://trac.webkit.org/changeset/131851
>
Ryuan Choi
Comment 6
2012-10-18 21:13:18 PDT
(In reply to
comment #4
)
> (From update of
attachment 169384
[details]
) > Looks make sense. Please landing this after verifying there is no problem in both release and debug API test.
I verified API tests of both release and debug. It works fine in my local.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug