Bug 99681 – [EFL][WK2] Move ewk_{init,shutdown}() to the main() function of EFL API test.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Eunmi Lee]

The ewk_{init,shutdown} is called whenever processing the each test (i.e. creating and deleting ewk_view),
so tests can be failed if EFL libraries functions are called between ewk_shutdown() and next ewk_init().

In the current codes,
initializing and shutdown are done in the RunLoop() and RunLoop() is created only one time during testing, so there is no problem.
However, the problem appears when we move initializing and shutdown of EFL libraries to the ewk_{init, shutdown}() by https://bugs.webkit.org/show_bug.cgi?id=97173.

The initializing and shutdown codes have to be in the ewk_{init,shutdown} not RunLoop().
So, I fix the EFL API test codes firstly to prevent before failing tests by https://bugs.webkit.org/show_bug.cgi?id=97173.

[Eunmi Lee]

Created attachment 169384 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 169384 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169384&action=review

> Source/WebKit2/ChangeLog:9
> +        so tests can be failed if EFL libraries APIs are called between

Is it possible EFL API is called between ewk_shutdown and next ewk_init ?

[Eunmi Lee]

(In reply to comment #2)
> (From update of attachment 169384 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=169384&action=review
> 
> > Source/WebKit2/ChangeLog:9
> > +        so tests can be failed if EFL libraries APIs are called between
> 
> Is it possible EFL API is called between ewk_shutdown and next ewk_init ?

Sure, that is the problem of API tests.

The ecore_pipe_write() can be called to send/receive between ui process and web process,
and ecore_timer APIs can be called to test with url loading.

They are failed with Bug 97173 because RunLoop does not cover their fault anymore.

[Gyuyoung Kim]

Comment on attachment 169384 [details]
Patch

Looks make sense. Please landing this after verifying there is no problem in both release and debug API test.

[Ryuan Choi]

Committed r131851: <http://trac.webkit.org/changeset/131851>

[Ryuan Choi]

(In reply to comment #4)
> (From update of attachment 169384 [details])
> Looks make sense. Please landing this after verifying there is no problem in both release and debug API test.

I verified API tests of both release and debug.
It works fine in my local.