Bug 99679 – webkit-gtk 1.10.0 fails to build JavaScriptCore/llint on darwin

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Jeremy Huddleston Sequoia]

1.8.3 built fine.  1.10.0 fails to build.

The error I encounter is:

libtool: compile:  /usr/bin/llvm-g++-4.2 -DHAVE_CONFIG_H -I. -Wall -W -Wcast-align -Wchar-subscripts -Wreturn-type -Wformat -Wformat-security -Wno-format-y2k -Wundef -Wmissing-format-attribute -Wpointer-arith -Wwrite-strings -Wno-unused-parameter -Wno-parentheses -fno-exceptions -DENABLE_GLIB_SUPPORT=1 -DBUILDING_CAIRO__=1 -DBUILDING_GTK__=1 -DBUILDING_SOUP__=1 -DWTF_CHANGES -DXP_UNIX -DMOZ_X11 -DWTF_USE_ICU_UNICODE=1 -DWTF_USE_GSTREAMER=1 -DWTF_USE_ACCELERATED_COMPOSITING=1 -DENABLE_3D_RENDERING=1 -DWTF_USE_TEXTURE_MAPPER=1 -DWTF_USE_TEXTURE_MAPPER_GL=1 -DWTF_USE_GLX=1 -DWTF_USE_OPENGL=1 -DGTK_API_VERSION_2=1 -DNDEBUG -I./Source -I./Source/JavaScriptCore -I./Source/JavaScriptCore/API -I./Source/JavaScriptCore/assembler -I./Source/JavaScriptCore/bytecode -I./Source/JavaScriptCore/bytecompiler -I./Source/JavaScriptCore/dfg -I./Source/JavaScriptCore/disassembler -I./Source/JavaScriptCore/heap -I./Source/JavaScriptCore/debugger -I./Source/JavaScriptCore/ForwardingHeaders -I./Source/JavaScriptCore/interpreter -I./Source/JavaScriptCore/jit -I./Source/JavaScriptCore/jit -I./Source/JavaScriptCore/llint -I./Source/JavaScriptCore/parser -I./Source/JavaScriptCore/profiler -I./Source/JavaScriptCore/runtime -I./Source/JavaScriptCore/tools -I./Source/JavaScriptCore/yarr -I./DerivedSources/JavaScriptCore -I./Source/WTF -fno-rtti -fstrict-aliasing -O3 -D_REENTRANT -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -I/opt/local/include -I/opt/local/include -pipe -O2 -arch x86_64 -O2 -MT Source/JavaScriptCore/llint/libjavascriptcoregtk_1_0_la-LowLevelInterpreter.lo -MD -MP -MF Source/JavaScriptCore/llint/.deps/libjavascriptcoregtk_1_0_la-LowLevelInterpreter.Tpo -c Source/JavaScriptCore/llint/LowLevelInterpreter.cpp  -fno-common -DPIC -o Source/JavaScriptCore/llint/.libs/libjavascriptcoregtk_1_0_la-LowLevelInterpreter.o
In file included from Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:36:
./DerivedSources/JavaScriptCore/LLIntAssembly.h:15: error: expected `)' before 'LOCAL_LABEL_STRING'
make[1]: *** [Source/JavaScriptCore/llint/libjavascriptcoregtk_1_0_la-LowLevelInterpreter.lo] Error 1
make: *** [all] Error 2

The preprocessed source is attached as LowLevelInterpreter.ii

It looks like LOCAL_LABEL_STRING is an undefined macro.  grepping through source, it looks like it's supposed to be defined in InlineASM.h:

#if PLATFORM(MAC)
#define LOCAL_LABEL_STRING(name) "L" #name
#elif OS(LINUX)
#define LOCAL_LABEL_STRING(name) ".L" #name
#endif

It looks like LOCAL_LABEL_STRING is undefined for many configs.  Furthermore, that '#if PLATFORM(MAC)' should probably be '#if OS(DARWIN) || OS(IOS)'

Although I don't quite understand why you have OS(IOS) and OS(DARWIN) since iOS is darwin...

[Jeremy Huddleston Sequoia]

Ah, ok, OS(DARWIN) is a superset of OS(IOS) and OS(MAC_OS_X), but yeah ... this should not be based on PLATFORM() which seems to determine toolkits used rather than architecture.

[Jeremy Huddleston Sequoia]

Source/WTF/wtf/InlineASM.h has been fixed.