[V8] Don't generate code that declares visitDOMWrapper if we're not going to generate the implementation
Created attachment 169292 [details] Patch
Comment on attachment 169292 [details] Patch Ha!
Comment on attachment 169292 [details] Patch Clearing flags on attachment: 169292 Committed r131673: <http://trac.webkit.org/changeset/131673>
All reviewed patches have been landed. Closing bug.
bindings-generation-tests are failing after this patch. They probably need to be rebaselined: http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Debug/builds/7350/steps/bindings-generation-tests/logs/stdio
(In reply to comment #5) > bindings-generation-tests are failing after this patch. They probably need to be rebaselined: > http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Debug/builds/7350/steps/bindings-generation-tests/logs/stdio Fixed in r131706. Sorry for the trouble.
Thanks Kentaro. It's me who should be apologizing.
Windows is still failing. Are there Windows specific results for the binding tests?
(In reply to comment #8) > Windows is still failing. Are there Windows specific results for the binding tests? http://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Tests%29/builds/29044 I'll try just rebaselining locally to see what happens.
(In reply to comment #9) > (In reply to comment #8) > > Windows is still failing. Are there Windows specific results for the binding tests? > > http://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Tests%29/builds/29044 > > I'll try just rebaselining locally to see what happens. Oops, that's from before the fix landing...my bad. Windows bots went down/stopped testing just before the fix it seems.