Bug 99653 - [V8] Don't generate code that declares visitDOMWrapper if we're not going to generate the implementation
Summary: [V8] Don't generate code that declares visitDOMWrapper if we're not going to ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-17 16:22 PDT by Adam Barth
Modified: 2012-10-18 14:29 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.72 KB, patch)
2012-10-17 16:22 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-10-17 16:22:42 PDT 
[V8] Don't generate code that declares visitDOMWrapper if we're not going to generate the implementation
Comment 1 Adam Barth 2012-10-17 16:22:59 PDT 
Created attachment 169292 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-10-17 16:28:21 PDT 
Comment on attachment 169292 [details]
Patch

Ha!
Comment 3 WebKit Review Bot 2012-10-17 17:04:02 PDT 
Comment on attachment 169292 [details]
Patch

Clearing flags on attachment: 169292

Committed r131673: <http://trac.webkit.org/changeset/131673>
Comment 4 WebKit Review Bot 2012-10-17 17:04:06 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Chris Dumez 2012-10-17 22:50:50 PDT 
bindings-generation-tests are failing after this patch. They probably need to be rebaselined:
http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Debug/builds/7350/steps/bindings-generation-tests/logs/stdio
Comment 6 Kentaro Hara 2012-10-17 22:56:16 PDT 
(In reply to comment #5)
> bindings-generation-tests are failing after this patch. They probably need to be rebaselined:
> http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Debug/builds/7350/steps/bindings-generation-tests/logs/stdio

Fixed in r131706. Sorry for the trouble.
Comment 7 Adam Barth 2012-10-17 23:08:22 PDT 
Thanks Kentaro.  It's me who should be apologizing.
Comment 8 Roger Fong 2012-10-18 06:17:59 PDT 
Windows is still failing. Are there Windows specific results for the binding tests?
Comment 9 Roger Fong 2012-10-18 12:00:59 PDT 
(In reply to comment #8)
> Windows is still failing. Are there Windows specific results for the binding tests?

http://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Tests%29/builds/29044

I'll try just rebaselining locally to see what happens.
Comment 10 Roger Fong 2012-10-18 14:29:02 PDT 
(In reply to comment #9)
> (In reply to comment #8)
> > Windows is still failing. Are there Windows specific results for the binding tests?
> 
> http://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Tests%29/builds/29044
> 
> I'll try just rebaselining locally to see what happens.

Oops, that's from before the fix landing...my bad.
Windows bots went down/stopped testing just before the fix it seems.