Bug 99648 - Remove redundant sdk_build parameter.
Summary: Remove redundant sdk_build parameter.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-17 15:53 PDT by Shashi Shekhar
Modified: 2012-10-17 17:48 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.57 KB, patch)
2012-10-17 15:54 PDT, Shashi Shekhar
no flags Details | Formatted Diff | Diff
Remove redundant sdk_build parameter. (2.04 KB, patch)
2012-10-17 16:10 PDT, Shashi Shekhar
no flags Details | Formatted Diff | Diff
Remove redundant sdk_build parameter. (2.04 KB, patch)
2012-10-17 16:26 PDT, Shashi Shekhar
no flags Details | Formatted Diff | Diff
Patch (3.42 KB, patch)
2012-10-17 16:56 PDT, Shashi Shekhar
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shashi Shekhar 2012-10-17 15:53:38 PDT
Remove redundant sdk_build parameter.
Comment 1 Shashi Shekhar 2012-10-17 15:54:58 PDT
Created attachment 169283 [details]
Patch
Comment 2 Shashi Shekhar 2012-10-17 16:10:23 PDT
Created attachment 169284 [details]
Remove redundant sdk_build parameter.
Comment 3 Shashi Shekhar 2012-10-17 16:26:04 PDT
Created attachment 169295 [details]
Remove redundant sdk_build parameter.
Comment 4 Peter Beverloo 2012-10-17 16:38:12 PDT
Looking at your Chromium change (http://src.chromium.org/viewvc/chrome?view=rev&revision=161127), this looks good to me. 

Adam, would you mind doing formal review?
Shashi, do you also want to request this to be committed? If so, you can click on "details" next to your patch and select the question mark in the "commit-queue" box.
Comment 5 Peter Beverloo 2012-10-17 16:39:08 PDT
Looking again, this does need a ChangeLog.
Comment 6 Adam Barth 2012-10-17 16:40:04 PDT
Comment on attachment 169295 [details]
Remove redundant sdk_build parameter.

Yeah, we need a ChangeLog entry for this patch.
Comment 7 Shashi Shekhar 2012-10-17 16:56:08 PDT
Created attachment 169302 [details]
Patch
Comment 8 Shashi Shekhar 2012-10-17 17:03:23 PDT
Comment on attachment 169302 [details]
Patch

Thanks, Peter this patch is part of cleanup of our scripts, other instances for sdk_build in Chromium has been cleaned up.
Patch you mentioned is correct:
http://src.chromium.org/viewvc/chrome?view=rev&revision=161127
Currently this parameter is a no-op, we will remove it once WebKit is also updated.
Comment 9 Shashi Shekhar 2012-10-17 17:08:26 PDT
Done.
(In reply to comment #6)
> (From update of attachment 169295 [details])
> Yeah, we need a ChangeLog entry for this patch.
Comment 10 Adam Barth 2012-10-17 17:11:10 PDT
Comment on attachment 169302 [details]
Patch

Thanks.
Comment 11 WebKit Review Bot 2012-10-17 17:13:32 PDT
Comment on attachment 169302 [details]
Patch

Rejecting attachment 169302 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/JavaScriptCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/14397791
Comment 12 WebKit Review Bot 2012-10-17 17:47:57 PDT
Comment on attachment 169302 [details]
Patch

Clearing flags on attachment: 169302

Committed r131681: <http://trac.webkit.org/changeset/131681>
Comment 13 WebKit Review Bot 2012-10-17 17:48:01 PDT
All reviewed patches have been landed.  Closing bug.