RESOLVED FIXED99638
webkitpy: fix chromium bot configs in builders.py 
https://bugs.webkit.org/show_bug.cgi?id=99638
Summary webkitpy: fix chromium bot configs in builders.py
Dirk Pranke
Reported 2012-10-17 14:01:56 PDT
webkitpy: fix chromium bot configs in builders.py
Attachments
Patch (3.44 KB, patch)
2012-10-17 14:03 PDT, Dirk Pranke 		ojan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-10-17 14:03:08 PDT
Created attachment 169258 [details] Patch
Ojan Vafai
Comment 2 2012-10-17 14:51:08 PDT
Comment on attachment 169258 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169258&action=review > Tools/Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:-94 > - self.assertEquals(extrapolator.extrapolate_test_configurations("WebKit Win7"), set([ Why is this case not needed?
Dirk Pranke
Comment 3 2012-10-17 14:54:21 PDT
I don't actually know what it was originally needed for. I pinged abarth about it and he thought it was no longer needed and safe to remove.
Adam Barth
Comment 4 2012-10-17 15:11:29 PDT
Comment on attachment 169258 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169258&action=review >> Tools/Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:-94 >> - self.assertEquals(extrapolator.extrapolate_test_configurations("WebKit Win7"), set([ > > Why is this case not needed? We don't use BuildCoverageExtrapolator anymore. We should probably rip it out.
Ojan Vafai
Comment 5 2012-10-17 15:11:50 PDT
sgtm
Dirk Pranke
Comment 6 2012-10-18 14:16:49 PDT
Committed r131800: <http://trac.webkit.org/changeset/131800>
Note You need to log in before you can comment on or make changes to this bug.