Bug 99625 - fast/forms/range/input-appearance-range-rtl.html off by one pixel
Summary: fast/forms/range/input-appearance-range-rtl.html off by one pixel
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-17 12:00 PDT by Tony Chang
Modified: 2012-10-17 15:33 PDT (History)
4 users (show)

See Also:

Attachments
Patch (5.33 KB, patch)
2012-10-17 12:05 PDT, Tony Chang 		no flags Details | Formatted Diff | Diff
rebase (4.73 KB, patch)
2012-10-17 14:51 PDT, Tony Chang 		no flags Details | Formatted Diff | Diff
Patch for landing (4.73 KB, patch)
2012-10-17 14:59 PDT, Tony Chang 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2012-10-17 12:00:09 PDT 
fast/forms/range/input-appearance-range-rtl.html off by one pixel
Comment 1 Tony Chang 2012-10-17 12:05:37 PDT 
Created attachment 169231 [details]
Patch
Comment 2 Tony Chang 2012-10-17 14:51:22 PDT 
Created attachment 169266 [details]
rebase
Comment 3 Ojan Vafai 2012-10-17 14:54:46 PDT 
Comment on attachment 169266 [details]
rebase

View in context: https://bugs.webkit.org/attachment.cgi?id=169266&action=review

> Source/WebCore/html/shadow/SliderThumbElement.cpp:176
> +        // Work around rounding issues in RTL vertical sliders. We want them to render
> +        // identically to LTR vertical sliders. We can remove this work around when
> +        // subpixel rendering is enabled on all ports.

Make this a FIXME?
Comment 4 Tony Chang 2012-10-17 14:59:34 PDT 
Created attachment 169269 [details]
Patch for landing
Comment 5 WebKit Review Bot 2012-10-17 15:33:33 PDT 
Comment on attachment 169269 [details]
Patch for landing

Clearing flags on attachment: 169269

Committed r131657: <http://trac.webkit.org/changeset/131657>
Comment 6 WebKit Review Bot 2012-10-17 15:33:37 PDT 
All reviewed patches have been landed.  Closing bug.