Bug 99622 – Clean up Vector.h

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

Clean up Vector.h

[Anders Carlsson]

Created attachment 169227 [details]
Patch

[Benjamin Poulain]

Comment on attachment 169227 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169227&action=review

> Source/WTF/WTF.xcodeproj/project.pbxproj:1183
> +				1A6BB769162F300500DD16DB /* StreamBuffer.h in Headers */,

The build section should be sorted alphabetically. The MemoryInstrumentationFooBar and WTFURL files are in the wrong place.

[Andreas Kling]

Comment on attachment 169227 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169227&action=review

> Source/WTF/WTF.xcodeproj/project.pbxproj:1183
> +				1A6BB769162F300500DD16DB /* StreamBuffer.h in Headers */,

The build section should be sorted alphabetically. The MemoryInstrumentationFooBar and WTFURL files are in the wrong place.

[Anders Carlsson]

(In reply to comment #3)
> (From update of attachment 169227 [details] [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=169227&action=review
> 
> > Source/WTF/WTF.xcodeproj/project.pbxproj:1183
> > +				1A6BB769162F300500DD16DB /* StreamBuffer.h in Headers */,
> 
> The build section should be sorted alphabetically. The MemoryInstrumentationFooBar and WTFURL files are in the wrong place.

They are sorted alphabetically in Xcode. Not sure why the project file is different.

[Benjamin Poulain]

> They are sorted alphabetically in Xcode. Not sure why the project file is different.

There are two sections.
The file section, which is the one you see on the Project Navigator, and a build section, that is buried deep in the project settings (Project->Targets->Build phases->Copy Headers && Compile Source).

It is just unfortunate the build section is not sorted by default.

[Build Bot]

Comment on attachment 169227 [details]
Patch

Attachment 169227 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/14391661

[WebKit Review Bot]

Comment on attachment 169227 [details]
Patch

Attachment 169227 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14392680

[Build Bot]

Comment on attachment 169227 [details]
Patch

Attachment 169227 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14390649

[Gyuyoung Kim]

Comment on attachment 169227 [details]
Patch

Attachment 169227 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14424203

[Peter Beverloo (cr-android ews)]

Comment on attachment 169227 [details]
Patch

Attachment 169227 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/14412232

[Anders Carlsson]

Created attachment 169263 [details]
Patch

[Benjamin Poulain]

Comment on attachment 169263 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169263&action=review

> Source/WTF/WTF.xcodeproj/project.pbxproj:1184
>  				F3FBC71E161AF7BF00BB4BD4 /* MemoryInstrumentationHashCountedSet.h in Headers */,
>  				F3FBC720161AF7CD00BB4BD4 /* MemoryInstrumentationSequence.h in Headers */,
> +				1A6BB769162F300500DD16DB /* StreamBuffer.h in Headers */,
>  			);

Uh? :(

[Anders Carlsson]

(In reply to comment #12)
> (From update of attachment 169263 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=169263&action=review
> 
> > Source/WTF/WTF.xcodeproj/project.pbxproj:1184
> >  				F3FBC71E161AF7BF00BB4BD4 /* MemoryInstrumentationHashCountedSet.h in Headers */,
> >  				F3FBC720161AF7CD00BB4BD4 /* MemoryInstrumentationSequence.h in Headers */,
> > +				1A6BB769162F300500DD16DB /* StreamBuffer.h in Headers */,
> >  			);
> 
> Uh? :(

It's explained in the ChangeLog.

[Anders Carlsson]

(In reply to comment #5)
> > They are sorted alphabetically in Xcode. Not sure why the project file is different.
> 
> There are two sections.
> The file section, which is the one you see on the Project Navigator, and a build section, that is buried deep in the project settings (Project->Targets->Build phases->Copy Headers && Compile Source).
> 
> It is just unfortunate the build section is not sorted by default.

Ah. Makes sense. I went ahead and sorted all files in the project. I'll update the ChangeLog to reflect this.

[Anders Carlsson]

Committed r131659: <http://trac.webkit.org/changeset/131659>