Default handling for GestureDoubleTap is a little too broad.
Created attachment 169220 [details] #If out some ANDROID-specific code.
For the record, this was introduced in bug 90316. The behavior on desktop was non-deterministic somehow, it was driving us nuts that a few people complained of this on ChromeOS but we couldn't reproduce it widely for some reason.
Seems fine for you to disable this code. But the normal way to do this in WebKit is to add a WebSetting. We should add one for double-tap zoom.
trchen, can you convert this to use a a WebSetting
yusufo is working on this
Created attachment 169662 [details] Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment on attachment 169662 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169662&action=review > Source/WebKit/chromium/src/WebSettingsImpl.h:169 > + bool doubleTapToZoomEnabled() {return m_doubleTapToZoomEnabled; } Nit: missing whitespace > Source/WebKit/chromium/src/WebViewImpl.cpp:778 > + if (!m_webSettings->doubleTapToZoomEnabled()) We don't want to break right away, we want it to be handled by WebCore below.
Created attachment 169665 [details] Patch
LGTM. Adam, could you r+?
Comment on attachment 169665 [details] Patch Rejecting attachment 169665 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ommit-queue/Source/WebKit/chromium/third_party/snappy/src --revision 63 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 49>At revision 63. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/14461554
Created attachment 169687 [details] Patch
Comment on attachment 169687 [details] Patch Clearing flags on attachment: 169687 Committed r131965: <http://trac.webkit.org/changeset/131965>
All reviewed patches have been landed. Closing bug.