Bug 99564 - [WK2][GTK] Unneeded GError field in internal structure in WebKitFaviconDatabase.cpp
Summary: [WK2][GTK] Unneeded GError field in internal structure in WebKitFaviconDataba...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2012-10-17 01:28 PDT by Mario Sanchez Prada
Modified: 2012-10-17 02:27 PDT (History)
4 users (show)

See Also:


Attachments
Patch proposal (3.71 KB, patch)
2012-10-17 01:33 PDT, Mario Sanchez Prada
cgarcia: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mario Sanchez Prada 2012-10-17 01:28:02 PDT
The field 'error' in GetFaviconSurfaceAsyncData is not needed and we should remove it and update the code accordingly
Comment 1 Mario Sanchez Prada 2012-10-17 01:33:33 PDT
Created attachment 169121 [details]
Patch proposal

The patch
Comment 2 WebKit Review Bot 2012-10-17 01:35:38 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Mario Sanchez Prada 2012-10-17 02:27:49 PDT
Committed r131569: <http://trac.webkit.org/changeset/131569>