Bug 99548 - Live oversize copied blocks should count toward overall heap fragmentation
Summary: Live oversize copied blocks should count toward overall heap fragmentation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-16 23:31 PDT by Mark Hahnenberg
Modified: 2012-10-18 16:20 PDT (History)
1 user (show)

See Also:

Attachments
Patch (5.87 KB, patch)
2012-10-18 15:07 PDT, Mark Hahnenberg 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2012-10-16 23:31:07 PDT 
The CopiedSpace uses overall heap fragmentation to determine whether or not it should do any copying. Currently it doesn't include live oversize CopiedBlocks in the calculation, but it should. We can also free any dead oversize CopiedBlocks while we're iterating over them, rather than iterating over them again at the end of the copying phase.
Comment 1 Mark Hahnenberg 2012-10-18 15:07:13 PDT 
Created attachment 169482 [details]
Patch
Comment 2 WebKit Review Bot 2012-10-18 15:42:46 PDT 
Comment on attachment 169482 [details]
Patch

Clearing flags on attachment: 169482

Committed r131818: <http://trac.webkit.org/changeset/131818>
Comment 3 WebKit Review Bot 2012-10-18 15:42:49 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Geoffrey Garen 2012-10-18 16:20:07 PDT 
Comment on attachment 169482 [details]
Patch

r=me