Bug 9954 - REGRESSION: document.dir should return empty string in <head>
Summary: REGRESSION: document.dir should return empty string in <head>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P1 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: Regression
Depends on:
Blocks:
 
Reported: 2006-07-16 07:15 PDT by David Kilzer (:ddkilzer)
Modified: 2007-06-24 12:04 PDT (History)
1 user (show)

See Also:

Attachments
Patch v1 (4.36 KB, patch)
2006-07-16 08:29 PDT, David Kilzer (:ddkilzer) 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2006-07-16 07:15:27 PDT 
The patch for Bug 9911 caused a minor regression where document.dir should return an empty string in <head>.  This matches what production Safari 2.0.4 (419.3) does.

Note that Bug 9947 covers the "real" fix to document.dir, which can't be set in <head> and which is currently linked to body.dir (unlike Firefox and MSIE).
Comment 1 David Kilzer (:ddkilzer) 2006-07-16 08:29:02 PDT 
Created attachment 9493 [details]
Patch v1

Changes document.dir to return an empty string instead of undef in <head>.
Comment 2 Darin Adler 2006-07-16 15:27:55 PDT 
Comment on attachment 9493 [details]
Patch v1

r=me
Comment 3 David Kilzer (:ddkilzer) 2006-07-16 21:15:17 PDT 
Committed revision 15479.
Comment 4 David Kilzer (:ddkilzer) 2007-06-24 12:04:44 PDT 
Mass removal of NeedsRadar keyword from my bugs that have already been RESOLVED.