RESOLVED FIXED 99539
Fix build warnings : -Wunused-parameter, -Wunused-variable 
https://bugs.webkit.org/show_bug.cgi?id=99539
Summary Fix build warnings : -Wunused-parameter, -Wunused-variable
Byungwoo Lee
Reported 2012-10-16 22:21:44 PDT
Fix build warnings about unused parameter or variable when WTF_USE_TILED_BACKING_STORE is enabled.
Attachments
Patch (25.18 KB, patch)
2012-10-16 22:41 PDT, Byungwoo Lee 		no flags
DetailsFormatted DiffDiff
Patch (25.01 KB, patch)
2012-10-17 03:08 PDT, Byungwoo Lee 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Byungwoo Lee
Comment 1 2012-10-16 22:41:07 PDT
Created attachment 169091 [details] Patch
Kentaro Hara
Comment 2 2012-10-17 00:39:09 PDT
Comment on attachment 169091 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169091&action=review Let's rebase with the latest WebKit and make bots green. > Source/WebCore/platform/graphics/texmap/TextureMapper.h:76 > + virtual bool canReuseWith(const IntSize& /* contentsSize */, Flags flags = 0) You can write 'Flags = 0' and remove UNUSED_PARAM(). > Source/WebCore/platform/graphics/texmap/TextureMapper.h:147 > + virtual void beginPainting(PaintFlags flags = 0) Ditto. > Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:410 > +void TextureMapperLayer::flushCompositingStateSelf(GraphicsLayerTextureMapper* graphicsLayer, TextureMapper* /* textureMapper */) Remove this argument instead of commenting out.
Byungwoo Lee
Comment 3 2012-10-17 02:27:16 PDT
(In reply to comment #2) > (From update of attachment 169091 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=169091&action=review > > Let's rebase with the latest WebKit and make bots green. > > > Source/WebCore/platform/graphics/texmap/TextureMapper.h:76 > > + virtual bool canReuseWith(const IntSize& /* contentsSize */, Flags flags = 0) > > You can write 'Flags = 0' and remove UNUSED_PARAM(). > > > Source/WebCore/platform/graphics/texmap/TextureMapper.h:147 > > + virtual void beginPainting(PaintFlags flags = 0) > > Ditto. > > > Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:410 > > +void TextureMapperLayer::flushCompositingStateSelf(GraphicsLayerTextureMapper* graphicsLayer, TextureMapper* /* textureMapper */) > > Remove this argument instead of commenting out. Thanks for the comment. I'll do those :)
Byungwoo Lee
Comment 4 2012-10-17 03:08:23 PDT
Created attachment 169145 [details] Patch
WebKit Review Bot
Comment 5 2012-10-17 10:15:19 PDT
Comment on attachment 169145 [details] Patch Clearing flags on attachment: 169145 Committed r131617: <http://trac.webkit.org/changeset/131617>
WebKit Review Bot
Comment 6 2012-10-17 10:15:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.