Bug 99537 – Hide popup while transitioning from the suggestion picker to the calendar picker

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Keishi Hattori]

Hide popup while transitioning from the suggestion picker to the calendar picker

[Keishi Hattori]

Created attachment 169083 [details]
Patch

[Kent Tamura]

Comment on attachment 169083 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169083&action=review

> LayoutTests/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step.html:8
> -    popupWindow.removeEventListener('resize', finishTest);
> +    popupWindow.removeEventListener('didOpenPicker', finishTest);

Would you apply a technique same as http://trac.webkit.org/changeset/131404 as possible before this change please?

[Keishi Hattori]

Created attachment 169128 [details]
Patch

[Kent Tamura]

Comment on attachment 169128 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169128&action=review

> LayoutTests/ChangeLog:9
> +        Use didOpenPicker event instead of resize event. Also refactoring
> +        tests to share the same structure.

Would you separate it into two patches please?

> LayoutTests/ChangeLog:37
> +        * platform/chromium/fast/forms/color/color-suggestion-picker-common.js: Added.

We usually put such helper library into resources/ subdirectory.

> LayoutTests/platform/chromium/TestExpectations:3904
> +webkit.org/b/99291 platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance.html [ Pass ImageOnlyFailure ]
> +webkit.org/b/99291 platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step.html [ Pass ImageOnlyFailure ]

This file already has lines for them.

> LayoutTests/platform/chromium/TestExpectations:3910
> +webkit.org/b/99291 platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance.html [ Pass ImageOnlyFailure ]
> +webkit.org/b/99291 platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar.html [ Pass ImageOnlyFailure ]
> +webkit.org/b/99291 platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance.html [ Pass ImageOnlyFailure ]
> +webkit.org/b/99291 platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar.html [ Pass ImageOnlyFailure ]

Ditto.

> LayoutTests/platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt:53
> -PASS focusedElement() is ".today-button[value=<<CalendarToday>>]"
> -PASS focusedElement() is ".clear-button[value=<<CalendarClear>>]"
> +FAIL focusedElement() should be .today-button[value=Today]. Was .today-button[value=<<CalendarToday>>].
> +FAIL focusedElement() should be .clear-button[value=Clear]. Was .clear-button[value=<<CalendarClear>>].
>  PASS focusedElement() is ".year-month-button[value=<<]"
> -PASS focusedElement() is ".clear-button[value=<<CalendarClear>>]"
> +FAIL focusedElement() should be .clear-button[value=Clear]. Was .clear-button[value=<<CalendarClear>>].

Is this an expected change?

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-key-operations.html:90
> -    popupWindow.addEventListener("resize", test1, false);
> +    popupWindow.addEventListener("didOpenPicker", test1, false);

Don't you use the callback argument of openPicker()?

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-key-operations.html:145
>      openPicker(document.getElementById('time'));
> -    popupWindow.addEventListener("resize", test2, false);
> +    popupWindow.addEventListener("didOpenPicker", test2, false);

ditto.

[Keishi Hattori]

Created attachment 169853 [details]
Patch

[Kent Tamura]

Comment on attachment 169853 [details]
Patch

ok

[WebKit Review Bot]

Comment on attachment 169853 [details]
Patch

Clearing flags on attachment: 169853

Committed r132553: <http://trac.webkit.org/changeset/132553>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.