Bug 99527 - IndexedDB: Stub out chromium success handlers for integers and undefined values
Summary: IndexedDB: Stub out chromium success handlers for integers and undefined values
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alec Flett
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-16 17:03 PDT by Alec Flett
Modified: 2012-10-16 18:30 PDT (History)
8 users (show)

See Also:


Attachments
Patch (1.83 KB, patch)
2012-10-16 17:04 PDT, Alec Flett
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alec Flett 2012-10-16 17:03:57 PDT
IndexedDB: Stub out chromium success handlers for integers and undefined values
Comment 1 Alec Flett 2012-10-16 17:04:37 PDT
Created attachment 169060 [details]
Patch
Comment 2 Alec Flett 2012-10-16 17:06:03 PDT
jsbell/dgrogan - quick review? I'm adding:

onSuccess(int64_t) - for the result of count(), previously calling onSuccess(SerializedScriptValue::numberValue(count))

onSuccess() - anytime we were calling onSuccess(SerializedScriptValue::undefinedValue())

This stubs these out so I can land chromium, then I'll have a webkit patch to follow
Comment 3 WebKit Review Bot 2012-10-16 17:07:03 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 Joshua Bell 2012-10-16 17:15:21 PDT
Comment on attachment 169060 [details]
Patch

LGTM. We may want to sort the lines so onSuccess() comes first.
Comment 5 Alec Flett 2012-10-16 17:24:19 PDT
abarth@ - r?
Comment 6 Adam Barth 2012-10-16 18:00:40 PDT
Comment on attachment 169060 [details]
Patch

Ok.
Comment 7 WebKit Review Bot 2012-10-16 18:30:19 PDT
Comment on attachment 169060 [details]
Patch

Clearing flags on attachment: 169060

Committed r131540: <http://trac.webkit.org/changeset/131540>
Comment 8 WebKit Review Bot 2012-10-16 18:30:23 PDT
All reviewed patches have been landed.  Closing bug.