RESOLVED FIXED 99523
HTMLSelectElement::optionSelectedByUser confuses listIndex and optionIndex 
https://bugs.webkit.org/show_bug.cgi?id=99523
Summary HTMLSelectElement::optionSelectedByUser confuses listIndex and optionIndex
Joseph Pecoraro
Reported 2012-10-16 16:23:40 PDT
HTMLSelectElement::optionSelectedByUser confuses listIndex and optionIndex. This breaks the ObjC binding to select element which call that method directly: -[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:].
Attachments
[PATCH] Proposed Fix (4.94 KB, patch)
2012-10-16 16:32 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2012-10-16 16:30:45 PDT
<rdar://problem/12363971>
Joseph Pecoraro
Comment 2 2012-10-16 16:32:03 PDT
Created attachment 169054 [details] [PATCH] Proposed Fix Without the patch, the test fails with the following output: Select multiple indexes, with multi-select on, in a <select multiple> with <optgroup>s. ** change event fired ** ** change event fired ** FAIL - option 0 was not what we expected. FAIL - option 2 was not what we expected.
Darin Adler
Comment 3 2012-10-16 17:18:01 PDT
Great fix!
WebKit Review Bot
Comment 4 2012-10-16 17:24:25 PDT
Comment on attachment 169054 [details] [PATCH] Proposed Fix Clearing flags on attachment: 169054 Committed r131534: <http://trac.webkit.org/changeset/131534>
WebKit Review Bot
Comment 5 2012-10-16 17:24:28 PDT
All reviewed patches have been landed. Closing bug.
Kent Tamura
Comment 6 2012-10-16 17:47:03 PDT
We should give different types to optionIndex and listIndex. At least typedefs, ideally their own classes...
Note You need to log in before you can comment on or make changes to this bug.