Bug 99497 - [BlackBerry] calculateInRegionScrollableAreasForPoint should use a ReadOnly HitTest
Summary: [BlackBerry] calculateInRegionScrollableAreasForPoint should use a ReadOnly H...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-16 13:42 PDT by Mike Lattanzio
Modified: 2012-10-17 07:14 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.91 KB, patch)
2012-10-16 14:04 PDT, Mike Lattanzio 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Lattanzio 2012-10-16 13:42:01 PDT 
void InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint(const WebCore::IntPoint& point) mistakenly passes a second parameter into     m_webPage->m_mainFrame->eventHandler()->hitTestResultAtPoint that slows down its hit test by making it not ReadOnly. 

Since this happens on the hot path to event handling it is important to improve it.
Comment 1 Mike Lattanzio 2012-10-16 14:04:38 PDT 
Created attachment 169020 [details]
Patch
Comment 2 Antonio Gomes 2012-10-16 14:56:59 PDT 
Comment on attachment 169020 [details]
Patch

Doh!

Someone changed the API and did not update our usage :/
Comment 3 WebKit Review Bot 2012-10-16 15:05:50 PDT 
Comment on attachment 169020 [details]
Patch

Clearing flags on attachment: 169020

Committed r131513: <http://trac.webkit.org/changeset/131513>
Comment 4 WebKit Review Bot 2012-10-16 15:05:54 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Rob Buis 2012-10-17 07:12:39 PDT 
Comment on attachment 169020 [details]
Patch

LGTM.