RESOLVED FIXED 99486
IndexedDB: Closing connection in upgradeneeded should result in error event 
https://bugs.webkit.org/show_bug.cgi?id=99486
Summary IndexedDB: Closing connection in upgradeneeded should result in error event
Joshua Bell
Reported 2012-10-16 11:43:44 PDT
IndexedDB: Closing connection in upgradeneeded should result in error event
Attachments
Patch (7.13 KB, patch)
2012-10-16 11:47 PDT, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Patch (7.14 KB, patch)
2012-10-17 15:43 PDT, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joshua Bell
Comment 1 2012-10-16 11:47:27 PDT
Created attachment 168991 [details] Patch
Joshua Bell
Comment 2 2012-10-16 11:49:16 PDT
This is a weird one. I think the behavior is more correct with this patch (and the updated test looks more correct), but I'm still feeling iffy about whether logic like this should go in enqueue vs. dispatch.
David Grogan
Comment 3 2012-10-16 15:52:11 PDT
Comment on attachment 168991 [details] Patch LGTM In the chromium bug you mentioned that this might just be postponing the flakiness but I can't see how failures would occur after this patch.
Joshua Bell
Comment 4 2012-10-16 16:26:26 PDT
(In reply to comment #3) > In the chromium bug you mentioned that this might just be postponing the flakiness but I can't see how failures would occur after this patch. Yeah, I agree - I don't recall what edge cases I might have been thinking of. As discussed offline, a more "elegant" approach than this patch would be to have the "complete" event dispatch send a message to the browser to unblock the success/error event, but this patch should have the equivalent from user script.
Joshua Bell
Comment 5 2012-10-16 17:14:15 PDT
Comment on attachment 168991 [details] Patch Actually, seeing some tests fail locally that may do an open and never see a success or an error.
Joshua Bell
Comment 6 2012-10-17 15:43:22 PDT
Created attachment 169279 [details] Patch
Joshua Bell
Comment 7 2012-10-17 15:44:55 PDT
(In reply to comment #5) > Actually, seeing some tests fail locally that may do an open and never see a success or an error. Whoops, that was a false alarm - I was running NRWT with a manually set and very low timeout. tony@ - r?
WebKit Review Bot
Comment 8 2012-10-17 16:51:08 PDT
Comment on attachment 169279 [details] Patch Clearing flags on attachment: 169279 Committed r131668: <http://trac.webkit.org/changeset/131668>
WebKit Review Bot
Comment 9 2012-10-17 16:51:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.