RESOLVED FIXED 99484
Change WTF_USE_8BIT_TEXTRUN to ENABLE_8BIT_TEXTRUN 
https://bugs.webkit.org/show_bug.cgi?id=99484
Summary Change WTF_USE_8BIT_TEXTRUN to ENABLE_8BIT_TEXTRUN
Michael Saboff
Reported 2012-10-16 11:19:47 PDT
In changeset <http://trac.webkit.org/changeset/131311>, the test macro WTF_USE_8BIT_TEXTRUN was used to control the use of 8 bit TextRuns. This macro should really be ENABLE_8BIT_TEXTRUN.
Attachments
Patch (6.55 KB, patch)
2012-10-16 11:39 PDT, Michael Saboff 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2012-10-16 11:39:19 PDT
Created attachment 168988 [details] Patch
Eric Seidel (no email)
Comment 2 2012-10-16 11:46:18 PDT
Comment on attachment 168988 [details] Patch SGTM. Levi should just be aware that he may have to re-base his chromium patch. I'm nto sure this one is so cut-and-dry an "ENABLE" instead of a USE. It isn't really a feature. It's platform-support, which is USE like you originally had it. :) Then again, I don't believe this matters. :)
WebKit Review Bot
Comment 3 2012-10-16 16:23:15 PDT
Comment on attachment 168988 [details] Patch Clearing flags on attachment: 168988 Committed r131526: <http://trac.webkit.org/changeset/131526>
WebKit Review Bot
Comment 4 2012-10-16 16:23:18 PDT
All reviewed patches have been landed. Closing bug.
Kent Tamura
Comment 5 2012-10-16 18:25:01 PDT
Would you add a description of 8BIT_TEXTRUN to https://trac.webkit.org/wiki/FeatureFlags please?
Michael Saboff
Comment 6 2012-10-17 09:00:34 PDT
(In reply to comment #5) > Would you add a description of 8BIT_TEXTRUN to https://trac.webkit.org/wiki/FeatureFlags please? Done.
Note You need to log in before you can comment on or make changes to this bug.