Bug 99484 - Change WTF_USE_8BIT_TEXTRUN to ENABLE_8BIT_TEXTRUN
Summary: Change WTF_USE_8BIT_TEXTRUN to ENABLE_8BIT_TEXTRUN
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-16 11:19 PDT by Michael Saboff
Modified: 2012-10-17 09:00 PDT (History)
6 users (show)

See Also:

Attachments
Patch (6.55 KB, patch)
2012-10-16 11:39 PDT, Michael Saboff 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2012-10-16 11:19:47 PDT 
In changeset <http://trac.webkit.org/changeset/131311>, the test macro WTF_USE_8BIT_TEXTRUN was used to control the use of 8 bit TextRuns.  This macro should really be ENABLE_8BIT_TEXTRUN.
Comment 1 Michael Saboff 2012-10-16 11:39:19 PDT 
Created attachment 168988 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-10-16 11:46:18 PDT 
Comment on attachment 168988 [details]
Patch

SGTM.  Levi should just be aware that he may have to re-base his chromium patch.  I'm nto sure this one is so cut-and-dry an "ENABLE" instead of a USE.  It isn't really a feature.  It's platform-support, which is USE like you originally had it. :)  Then again, I don't believe this matters. :)
Comment 3 WebKit Review Bot 2012-10-16 16:23:15 PDT 
Comment on attachment 168988 [details]
Patch

Clearing flags on attachment: 168988

Committed r131526: <http://trac.webkit.org/changeset/131526>
Comment 4 WebKit Review Bot 2012-10-16 16:23:18 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Kent Tamura 2012-10-16 18:25:01 PDT 
Would you add a description of 8BIT_TEXTRUN to https://trac.webkit.org/wiki/FeatureFlags please?
Comment 6 Michael Saboff 2012-10-17 09:00:34 PDT 
(In reply to comment #5)
> Would you add a description of 8BIT_TEXTRUN to https://trac.webkit.org/wiki/FeatureFlags please?

Done.