Bug 99479 - [EFL][WK2] Add factory methods for refcounted Ewk types
Summary: [EFL][WK2] Add factory methods for refcounted Ewk types
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 99321
  Show dependency tree / graph
 
Reported: 2012-10-16 10:58 PDT by Chris Dumez
Modified: 2012-10-16 19:21 PDT (History)
8 users (show)

See Also:

Attachments
Patch (34.06 KB, patch)
2012-10-16 11:34 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-10-16 10:58:17 PDT 
We should create factory methods for refcounted ewk types and get rid of private _new() functions. This makes the private API more C++ and promotes the use of smart pointers.
Comment 1 Chris Dumez 2012-10-16 11:34:28 PDT 
Created attachment 168987 [details]
Patch
Comment 2 Gyuyoung Kim 2012-10-16 19:17:32 PDT 
Comment on attachment 168987 [details]
Patch

LGTM.
Comment 3 WebKit Review Bot 2012-10-16 19:21:01 PDT 
Comment on attachment 168987 [details]
Patch

Clearing flags on attachment: 168987

Committed r131546: <http://trac.webkit.org/changeset/131546>
Comment 4 WebKit Review Bot 2012-10-16 19:21:05 PDT 
All reviewed patches have been landed.  Closing bug.