Bug 99472 - [EFL][WK2] Start using OwnPtr for non-ref counted ewk types
Summary: [EFL][WK2] Start using OwnPtr for non-ref counted ewk types
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-16 09:41 PDT by Chris Dumez
Modified: 2012-10-17 00:28 PDT (History)
8 users (show)

See Also:

Attachments
Patch (38.05 KB, patch)
2012-10-16 10:40 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (38.08 KB, patch)
2012-10-16 21:22 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-10-16 09:41:44 PDT 
We should start using OwnPtr internally for non-ref counted Ewk types.
Comment 1 Chris Dumez 2012-10-16 10:40:26 PDT 
Created attachment 168968 [details]
Patch
Comment 2 Chris Dumez 2012-10-16 21:22:51 PDT 
Created attachment 169082 [details]
Patch

Rebase on master.
Comment 3 Kenneth Rohde Christiansen 2012-10-17 00:15:00 PDT 
Comment on attachment 169082 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169082&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_cookie_manager_private.h:51
>  typedef struct _Ewk_Cookie_Manager Ewk_Cookie_Manager;

Why do we do these C style things?
Comment 4 Mikhail Pozdnyakov 2012-10-17 00:18:56 PDT 
(In reply to comment #3)
> (From update of attachment 169082 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=169082&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_cookie_manager_private.h:51
> >  typedef struct _Ewk_Cookie_Manager Ewk_Cookie_Manager;
> 
> Why do we do these C style things?

Think we can do the same as it's done in WK C API:

typedef struct WKPageLoaderClient WKPageLoaderClient;

That would let us to remove typedef from private header at all.
Comment 5 Mikhail Pozdnyakov 2012-10-17 00:20:06 PDT 
(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 169082 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=169082&action=review
> > 
> > > Source/WebKit2/UIProcess/API/efl/ewk_cookie_manager_private.h:51
> > >  typedef struct _Ewk_Cookie_Manager Ewk_Cookie_Manager;
> > 
> > Why do we do these C style things?
> 
> Think we can do the same as it's done in WK C API:
> 
> typedef struct WKPageLoaderClient WKPageLoaderClient;
> 
> That would let us to remove typedef from private header at all.

I mean use typedef struct Ewk_Cookie_Manager Ewk_Cookie_Manager; in public header.
Comment 6 WebKit Review Bot 2012-10-17 00:28:48 PDT 
Comment on attachment 169082 [details]
Patch

Clearing flags on attachment: 169082

Committed r131558: <http://trac.webkit.org/changeset/131558>
Comment 7 WebKit Review Bot 2012-10-17 00:28:53 PDT 
All reviewed patches have been landed.  Closing bug.