Bug 99460 – Implement the Selector argument to RTCPeerConnection.getStats

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Harald Alvestrand]

The Selector argument to RTCPeerConnection.getStats is supposed to give a single track that one wants to get statistics on, so that one does not have to fetch all stats all the time.

[Harald Alvestrand]

Created attachment 168937 [details]
Patch

[Tommy Widenflycht]

Comment on attachment 168937 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168937&action=review

> Source/WebCore/Modules/mediastream/RTCStatsRequestImpl.cpp:47
> +    , m_stream(selector?selector->streamDescriptor():0)

Space around operators

> Source/WebCore/Modules/mediastream/RTCStatsRequestImpl.cpp:66
> +PassRefPtr<MediaStreamDescriptor> RTCStatsRequestImpl::stream()

Only return a PassRefPtr is ownership is transfered, otherwise use raw pointers: return m_stream.get()
http://www.webkit.org/coding/RefPtr.html

> Source/WebCore/platform/mediastream/RTCStatsRequest.h:52
> +    virtual PassRefPtr<MediaStreamDescriptor> stream() = 0;

See the comment above.

[Harald Alvestrand]

Created attachment 168942 [details]
Patch

[Harald Alvestrand]

Created attachment 168946 [details]
Patch

[Harald Alvestrand]

Comment on attachment 168937 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168937&action=review

>> Source/WebCore/Modules/mediastream/RTCStatsRequestImpl.cpp:47
>> +    , m_stream(selector?selector->streamDescriptor():0)
> 
> Space around operators

Done.

>> Source/WebCore/Modules/mediastream/RTCStatsRequestImpl.cpp:66
>> +PassRefPtr<MediaStreamDescriptor> RTCStatsRequestImpl::stream()
> 
> Only return a PassRefPtr is ownership is transfered, otherwise use raw pointers: return m_stream.get()
> http://www.webkit.org/coding/RefPtr.html

Done.

>> Source/WebCore/platform/mediastream/RTCStatsRequest.h:52
>> +    virtual PassRefPtr<MediaStreamDescriptor> stream() = 0;
> 
> See the comment above.

Done.

[Tommy Widenflycht]

Comment on attachment 168946 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168946&action=review

> Source/WebCore/platform/chromium/support/WebRTCStatsRequest.cpp:68
>  

Nit: extra empty line

> Source/WebCore/platform/chromium/support/WebRTCStatsRequest.cpp:84
> +

Nit: extra empty line

[Adam Barth]

Comment on attachment 168946 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168946&action=review

This patch looks good.  Tommy and I have some very minor style issues that we should clear up before landing.

> Source/Platform/chromium/public/WebRTCStatsRequest.h:89
> +    WEBKIT_EXPORT bool hasSelector() const;
> +
> +    WEBKIT_EXPORT const WebMediaStreamDescriptor stream() const;
> +
> +    WEBKIT_EXPORT const WebMediaStreamComponent component() const;

I might have added some comments explaining the relationship between these functions.

[Rik Cabanier]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Harald Alvestrand]

Created attachment 169140 [details]
Patch for landing

[Harald Alvestrand]

Comment on attachment 168946 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168946&action=review

>> Source/Platform/chromium/public/WebRTCStatsRequest.h:89
>> +    WEBKIT_EXPORT const WebMediaStreamComponent component() const;
> 
> I might have added some comments explaining the relationship between these functions.

Done.

> Source/WebCore/platform/chromium/support/WebRTCStatsRequest.cpp:68
>  

Fixed.

>> Source/WebCore/platform/chromium/support/WebRTCStatsRequest.cpp:84
>> +
> 
> Nit: extra empty line

Fixed.

[WebKit Review Bot]

Comment on attachment 169140 [details]
Patch for landing

Rejecting attachment 169140 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Review Bot]

Comment on attachment 169140 [details]
Patch for landing

Clearing flags on attachment: 169140

Committed r131584: <http://trac.webkit.org/changeset/131584>