UNCONFIRMED 99398
Clean up some Media Source test cases implementation. 
https://bugs.webkit.org/show_bug.cgi?id=99398
Summary Clean up some Media Source test cases implementation.
Anand Chakravarty
Reported 2012-10-15 17:41:55 PDT
Some of the implemented test cases for the Media Source API have tests/functions that perform multiple actions. For easier tracking of test case coverage/failures and ease of maintenance, it would be good to better focus these test cases so that each test case implements only a specific scenario and not overload their purpose. A good candidate for reducing test case overloading is video-media-source-state-changes.html. It verifies multiple state transitions and it would be better to have a separate test for each set of state transitions we want to verify. An example where a test does more than it probably should is video-media-source-objects.html. This test, in addition to verifying the type and contents of different objects, also verifies that calls to append and buffered throws an error after SourceBuffer has been removed, and there is also another seemingly unnecessary check, for performing addSourceBuffer on a close media source, in the afterSourceBufferRemoved function. These extra checks are better implemented as separate test cases or, if they are already implemented elsewhere, just removed from this test to avoid duplication.
Attachments
Add attachment proposed patch, testcase, etc.
Note You need to log in before you can comment on or make changes to this bug.