WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
99367
Remove unused WTF_NEW_HASHMAP_ITERATORS_INTERFACE #define
https://bugs.webkit.org/show_bug.cgi?id=99367
Summary
Remove unused WTF_NEW_HASHMAP_ITERATORS_INTERFACE #define
Adrienne Walker
Reported
2012-10-15 14:23:54 PDT
Remove unused WTF_NEW_HASHMAP_ITERATORS_INTERFACE #define
Attachments
Patch
(1.39 KB, patch)
2012-10-15 14:25 PDT
,
Adrienne Walker
no flags
Details
Formatted Diff
Diff
For ews
(1.36 KB, patch)
2012-10-16 10:47 PDT
,
Adrienne Walker
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Adrienne Walker
Comment 1
2012-10-15 14:25:58 PDT
Created
attachment 168784
[details]
Patch
Adrienne Walker
Comment 2
2012-10-15 14:28:22 PDT
Not quite ready to land yet, just uploading a patch to say that I intend to remove this define soon. Waiting on these three patches to land:
https://codereview.chromium.org/11150024/
https://codereview.chromium.org/11144023/
https://codereview.chromium.org/11142025/
...and then those changes to roll into WK.
Benjamin Poulain
Comment 3
2012-10-15 15:23:29 PDT
Sweet!
Peter Beverloo (cr-android ews)
Comment 4
2012-10-15 16:54:41 PDT
Comment on
attachment 168784
[details]
Patch
Attachment 168784
[details]
did not pass cr-android-ews (chromium-android): Output:
http://queues.webkit.org/results/14286810
WebKit Review Bot
Comment 5
2012-10-15 18:05:36 PDT
Comment on
attachment 168784
[details]
Patch
Attachment 168784
[details]
did not pass chromium-ews (chromium-xvfb): Output:
http://queues.webkit.org/results/14299874
Adrienne Walker
Comment 6
2012-10-16 10:47:05 PDT
Created
attachment 168971
[details]
For ews
WebKit Review Bot
Comment 7
2012-10-16 12:06:23 PDT
Comment on
attachment 168971
[details]
For ews Clearing flags on attachment: 168971 Committed
r131484
: <
http://trac.webkit.org/changeset/131484
>
WebKit Review Bot
Comment 8
2012-10-16 12:06:28 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug