Rename some AudioNodes
Created attachment 168770 [details] Patch
Attachment 168770 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebCore/Modules/webaudio/AudioContext.cpp:37: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/Modules/webaudio/AudioContext.cpp:41: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/Modules/webaudio/AudioContext.cpp:52: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/Modules/webaudio/AudioContext.cpp:55: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/Modules/webaudio/AnalyserNode.h:48: Omit int when using unsigned [runtime/unsigned] [1] Source/WebCore/Modules/webaudio/AnalyserNode.h:49: Omit int when using unsigned [runtime/unsigned] [1] Source/WebCore/Modules/webaudio/ScriptProcessorNode.cpp:146: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WebCore/Modules/webaudio/ScriptProcessorNode.cpp:200: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WebCore/Modules/webaudio/AnalyserNode.cpp:68: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WebCore/Modules/webaudio/AnalyserNode.cpp:78: Omit int when using unsigned [runtime/unsigned] [1] Source/WebCore/Modules/webaudio/PannerNode.cpp:323: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WebCore/Modules/webaudio/OscillatorNode.cpp:221: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/Modules/webaudio/OscillatorNode.cpp:222: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/Modules/webaudio/OscillatorNode.cpp:223: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/Modules/webaudio/AudioBufferSourceNode.h:31: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 15 in 42 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 168801 [details] Patch
Comment on attachment 168801 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168801&action=review Please sort the file listing in the Xcode project file such that the files are listed according to the Unix sort command. > Source/WebCore/ChangeLog:37 > + (WebCore): > + (WebCore::AnalyserNode::AnalyserNode): > + (WebCore::AnalyserNode::~AnalyserNode): > + (WebCore::AnalyserNode::process): > + (WebCore::AnalyserNode::reset): > + (WebCore::AnalyserNode::setFftSize): We tend to omit the function listings when we rename a file since the functions have not actually changed. Omitting such listings will also decrease the length of the change log/commit message.
Committed r131486: <http://trac.webkit.org/changeset/131486>