Bug 99357 - Layout Test webaudio/codec-tests/vorbis/vbr-70kbps-44khz.html is failing
Summary: Layout Test webaudio/codec-tests/vorbis/vbr-70kbps-44khz.html is failing
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Rogers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-15 13:18 PDT by Dana Jansens
Modified: 2012-10-15 17:08 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dana Jansens 2012-10-15 13:18:58 PDT
The following layout test is failing on all platforms.

webaudio/codec-tests/vorbis/vbr-70kbps-44khz.html

Probable cause:

http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/62
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/66
Comment 1 Dana Jansens 2012-10-15 13:32:57 PDT
Committed r131346: <http://trac.webkit.org/changeset/131346>
Comment 2 Dana Jansens 2012-10-15 13:38:53 PDT
It sounds like it just needs a rebaseline to me, but I'm not exactly sure what may be important here.
Comment 3 Raymond Toy 2012-10-15 14:01:05 PDT
(In reply to comment #2)
> It sounds like it just needs a rebaseline to me, but I'm not exactly sure what may be important here.

I took a quick look at the vbr-70kbps-44khz test.  The data is exactly identical except the new version as added exactly one extra sample.  The expected wav file has 15434 samples, and the new actual wav file has 15435 samples.

I'm also getting a failure (locally on my Linux box) with webaudio/codec-tests/mp3/128kbps-44khz.html.  In this case, the files are exactly identical, except the expected file has 1105 extra (zero) samples at the end.

It looks like a recent ffmpeg update has changed this.
Comment 4 Raymond Toy 2012-10-15 14:09:21 PDT
dalecurtis@ says this was broken in http://codereview.chromium.org/11137005/ and Chris has a fix for this forthcoming.  Assigning to Chris.
Comment 5 Chris Rogers 2012-10-15 14:38:08 PDT
I just re-baselined Mac/Win and took out the expected failure -- I'll re-baseline Linux with garden-o-matic when it shows up.

http://trac.webkit.org/changeset/131361
Comment 6 Dana Jansens 2012-10-15 15:56:32 PDT
This has started failing in linux now, shall I rebaseline?
Comment 7 Chris Rogers 2012-10-15 15:59:38 PDT
(In reply to comment #6)
> This has started failing in linux now, shall I rebaseline?

Sorry, Dana, I just did:
http://trac.webkit.org/changeset/131376

Let me know if there are any other failures...

thanks!
Comment 8 Dana Jansens 2012-10-15 16:15:49 PDT
Thanks very much!
Comment 10 Dana Jansens 2012-10-15 17:08:48 PDT
Marked as failing again

Committed r131383: <http://trac.webkit.org/changeset/131383>