Bug 99339 - Make RenderTable columns() and columnPositions() return a const reference
Summary: Make RenderTable columns() and columnPositions() return a const reference
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tables (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Julien Chaffraix
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-15 10:57 PDT by Julien Chaffraix
Modified: 2012-10-15 14:52 PDT (History)
2 users (show)

See Also:


Attachments
Proposed change. Added more constness and a getter. (5.71 KB, patch)
2012-10-15 11:09 PDT, Julien Chaffraix
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Chaffraix 2012-10-15 10:57:05 PDT
The 2 functions currently return a mutable Vector reference. Only FixedTableLayout and AutoTableLayout are expected to change the values, yet most of the code is allowed to. The easy fix is to add a setter as needed so that unintended modifications are caught by the compiler.

Patch forthcoming.
Comment 1 Julien Chaffraix 2012-10-15 11:09:48 PDT
Created attachment 168743 [details]
Proposed change. Added more constness and a getter.
Comment 2 WebKit Review Bot 2012-10-15 14:52:25 PDT
Comment on attachment 168743 [details]
Proposed change. Added more constness and a getter.

Clearing flags on attachment: 168743

Committed r131366: <http://trac.webkit.org/changeset/131366>
Comment 3 WebKit Review Bot 2012-10-15 14:52:28 PDT
All reviewed patches have been landed.  Closing bug.