WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
99324
Web Inspector: Scripts for dynamically added script elements are not shown in sources panel.
https://bugs.webkit.org/show_bug.cgi?id=99324
Summary
Web Inspector: Scripts for dynamically added script elements are not shown in...
Vsevolod Vlasov
Reported
2012-10-15 07:24:40 PDT
Patch to follow.
Attachments
Patch
(13.26 KB, patch)
2012-10-15 07:56 PDT
,
Vsevolod Vlasov
pfeldman
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1
2012-10-15 07:31:05 PDT
Scripts added with var scriptElement = document.createElement("script"); scriptElement.src = url; document.head.appendChild(scriptElement); Are not shown if inspector is opened after the script was loaded. var scriptElement = document.createElement("script"); scriptElement.textContent = script; document.head.appendChild(scriptElement); are not shown at all.
Vsevolod Vlasov
Comment 2
2012-10-15 07:56:32 PDT
Created
attachment 168711
[details]
Patch
Vsevolod Vlasov
Comment 3
2012-10-15 08:06:18 PDT
Committed
r131302
: <
http://trac.webkit.org/changeset/131302
>
Csaba Osztrogonác
Comment 4
2012-10-15 08:58:38 PDT
(In reply to
comment #3
)
> Committed
r131302
: <
http://trac.webkit.org/changeset/131302
>
It broke 2 tests everywhere: --- /Volumes/Data/slave/lion-release-tests-wk1/build/layout-test-results/http/tests/inspector-enabled/dynamic-scripts-expected.txt +++ /Volumes/Data/slave/lion-release-tests-wk1/build/layout-test-results/http/tests/inspector-enabled/dynamic-scripts-actual.txt @@ -4,9 +4,5 @@ UISourceCodes: dynamic-script.js dynamic-scripts.html - dynamic-scripts.html (1) - dynamic-scripts.html (2) - evalSourceURL.js inspector-test.js - scriptElementContentSourceURL.js --- /Volumes/Data/slave/lion-release-tests-wk1/build/layout-test-results/inspector/debugger/dynamic-scripts-expected.txt +++ /Volumes/Data/slave/lion-release-tests-wk1/build/layout-test-results/inspector/debugger/dynamic-scripts-actual.txt @@ -5,9 +5,5 @@ UISourceCodes: dynamic-script.js dynamic-scripts.html - dynamic-scripts.html (1) - dynamic-scripts.html (2) - evalSourceURL.js inspector-test.js - scriptElementContentSourceURL.js
Vsevolod Vlasov
Comment 5
2012-10-15 09:46:20 PDT
Thanks for the headsup, Landed a fix: Committed
r131309
: <
http://trac.webkit.org/changeset/131309
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug