Bug 99322 – [EFL][WK2] Display tooltip in MiniBrowser

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Jinwoo Song]

Display tooltip in MiniBrowser using elm_object_tooltip_text_set().

[Jinwoo Song]

Created attachment 168707 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 168707 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168707&action=review

> Tools/MiniBrowser/efl/main.c:529
> +on_tooltip_text_set(void *user_data, Evas_Object *obj, void *event_info)

MiniBrowser's been used *webview* for Evas_Object variable name.

> Tools/MiniBrowser/efl/main.c:532
> +    char *message = (char *)event_info;

tooltip message is sent as const char. So, I think you have to use const char.

> Tools/MiniBrowser/efl/main.c:544
> +on_tooltip_text_unset(void *user_data, Evas_Object *obj, void *event_info)

ditto.

[Chris Dumez]

*** Bug 99846 has been marked as a duplicate of this bug. ***

[Chris Dumez]

Can you please take a look at my patch from Bug 99846 ?
It seems simpler and it was working fine based on my testing. Feel free to inspire from it.

[Chris Dumez]

Comment on attachment 168707 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168707&action=review

> Tools/MiniBrowser/efl/main.c:58
> +    Evas_Object *tooltip;

Why do we need to keep a pointer to the tooltip?

> Tools/MiniBrowser/efl/main.c:539
> +    evas_object_move(window->tooltip, x, y);

Why do we need to move it?

> Tools/MiniBrowser/efl/main.c:664
> +    app_data->tooltip = elm_label_add(app_data->window);

Why do we need a label?

[Jinwoo Song]

(In reply to comment #4)
> Can you please take a look at my patch from Bug 99846 ?
> It seems simpler and it was working fine based on my testing. Feel free to inspire from it.

Yes, it seems simpler way, but I see an error message from elementary. Is it a bug from elementary? How do you think about this?
ERR<4848>:elementary elm_label.c:400 elm_label_add() could not add 0x27641c0 as sub object of 0x250deb0'

[Chris Dumez]

(In reply to comment #6)
> (In reply to comment #4)
> > Can you please take a look at my patch from Bug 99846 ?
> > It seems simpler and it was working fine based on my testing. Feel free to inspire from it.
> 
> Yes, it seems simpler way, but I see an error message from elementary. Is it a bug from elementary? How do you think about this?
> ERR<4848>:elementary elm_label.c:400 elm_label_add() could not add 0x27641c0 as sub object of 0x250deb0'

Yes, I have seen this error on the terminal too. It looks like an elementary bug but the visual output looks correct.

[Jinwoo Song]

Created attachment 170677 [details]
Patch

[Jinwoo Song]

I refined the patch referring to Chris's simpler approach.

[Chris Dumez]

Comment on attachment 170677 [details]
Patch

LGTM.

[WebKit Review Bot]

Comment on attachment 170677 [details]
Patch

Clearing flags on attachment: 170677

Committed r132560: <http://trac.webkit.org/changeset/132560>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.