Bug 99317 - [WK2] Provide WKURL API for resolving the relative URL with the given base URL
Summary: [WK2] Provide WKURL API for resolving the relative URL with the given base URL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mikhail Pozdnyakov
URL:
Keywords:
Depends on:
Blocks: 42674
  Show dependency tree / graph
 
Reported: 2012-10-15 06:13 PDT by Mikhail Pozdnyakov
Modified: 2012-10-16 03:16 PDT (History)
5 users (show)

See Also:

Attachments
patch (3.24 KB, patch)
2012-10-15 06:32 PDT, Mikhail Pozdnyakov 		kenneth: review-
kenneth: commit-queue-
Details | Formatted Diff | Diff
patch v2 (6.28 KB, patch)
2012-10-16 02:26 PDT, Mikhail Pozdnyakov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Pozdnyakov 2012-10-15 06:13:17 PDT 
WKURL API resolving the relative URL with the given base URL would be very useful in many use cases, one of them is finding absolute URL
for WKPage if only relative URL is given (see https://bug-42674-attachments.webkit.org/attachment.cgi?id=168455 for bug42674)
Comment 1 Mikhail Pozdnyakov 2012-10-15 06:32:39 PDT 
Created attachment 168701 [details]
patch
Comment 2 mitz 2012-10-15 08:31:34 PDT 
No API test?
Comment 3 Kenneth Rohde Christiansen 2012-10-15 08:38:54 PDT 
Comment on attachment 168701 [details]
patch

Oops right, API tests should be added.
Comment 4 Mikhail Pozdnyakov 2012-10-16 01:42:33 PDT 
Seems we do not have tests for WKURL API at all.. but I can add..
Comment 5 Mikhail Pozdnyakov 2012-10-16 02:26:13 PDT 
Created attachment 168897 [details]
patch v2

Added test.
Comment 6 WebKit Review Bot 2012-10-16 03:16:55 PDT 
Comment on attachment 168897 [details]
patch v2

Clearing flags on attachment: 168897

Committed r131437: <http://trac.webkit.org/changeset/131437>
Comment 7 WebKit Review Bot 2012-10-16 03:16:58 PDT 
All reviewed patches have been landed.  Closing bug.