Bug 99316 - Web Inspector: display "disconnected" message when remote debugging terminates
Summary: Web Inspector: display "disconnected" message when remote debugging terminates
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-15 06:10 PDT by Pavel Feldman
Modified: 2012-10-17 05:49 PDT (History)
10 users (show)

See Also:


Attachments
Patch (2.60 KB, patch)
2012-10-15 06:12 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff
Patch (3.42 KB, patch)
2012-10-17 05:23 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-10-15 06:10:26 PDT
Otherwise, it is not clear that the front-end is no longer functional.
Comment 1 Pavel Feldman 2012-10-15 06:12:02 PDT
Created attachment 168697 [details]
Patch
Comment 2 Andrey Kosyakov 2012-10-17 05:16:56 PDT
Comment on attachment 168697 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168697&action=review

> Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js:232
> +    WebInspector.HelpScreen.call(this, WebInspector.UIString("Debug target terminated"));

add a localizedString for that?

> Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js:235
> +    p.textContent = WebInspector.UIString("This remote debugging client is no longer functional. Please re-attach to the new target.");

ditto

> Source/WebCore/inspector/front-end/inspector.js:338
> +        WebInspector.socket.onclose = function() {

{ => next line
Comment 3 Pavel Feldman 2012-10-17 05:23:08 PDT
Created attachment 169164 [details]
Patch
Comment 4 WebKit Review Bot 2012-10-17 05:48:57 PDT
Comment on attachment 169164 [details]
Patch

Clearing flags on attachment: 169164

Committed r131591: <http://trac.webkit.org/changeset/131591>
Comment 5 WebKit Review Bot 2012-10-17 05:49:01 PDT
All reviewed patches have been landed.  Closing bug.