WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
99316
Web Inspector: display "disconnected" message when remote debugging terminates
https://bugs.webkit.org/show_bug.cgi?id=99316
Summary
Web Inspector: display "disconnected" message when remote debugging terminates
Pavel Feldman
Reported
2012-10-15 06:10:26 PDT
Otherwise, it is not clear that the front-end is no longer functional.
Attachments
Patch
(2.60 KB, patch)
2012-10-15 06:12 PDT
,
Pavel Feldman
no flags
Details
Formatted Diff
Diff
Patch
(3.42 KB, patch)
2012-10-17 05:23 PDT
,
Pavel Feldman
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Pavel Feldman
Comment 1
2012-10-15 06:12:02 PDT
Created
attachment 168697
[details]
Patch
Andrey Kosyakov
Comment 2
2012-10-17 05:16:56 PDT
Comment on
attachment 168697
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=168697&action=review
> Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js:232 > + WebInspector.HelpScreen.call(this, WebInspector.UIString("Debug target terminated"));
add a localizedString for that?
> Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js:235 > + p.textContent = WebInspector.UIString("This remote debugging client is no longer functional. Please re-attach to the new target.");
ditto
> Source/WebCore/inspector/front-end/inspector.js:338 > + WebInspector.socket.onclose = function() {
{ => next line
Pavel Feldman
Comment 3
2012-10-17 05:23:08 PDT
Created
attachment 169164
[details]
Patch
WebKit Review Bot
Comment 4
2012-10-17 05:48:57 PDT
Comment on
attachment 169164
[details]
Patch Clearing flags on attachment: 169164 Committed
r131591
: <
http://trac.webkit.org/changeset/131591
>
WebKit Review Bot
Comment 5
2012-10-17 05:49:01 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug