Bug 99311 - REGRESSION(130613): Reintroduces crashes when using soup's timeout functionality
Summary: REGRESSION(130613): Reintroduces crashes when using soup's timeout functionality
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dominik Röttsches (drott)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-15 05:25 PDT by Dominik Röttsches (drott)
Modified: 2012-10-15 07:47 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.93 KB, patch)
2012-10-15 05:33 PDT, Dominik Röttsches (drott)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dominik Röttsches (drott) 2012-10-15 05:25:34 PDT
r130613 had
+     cleanupSoupRequestOperation(handle.get());
in requestTimeoutCallback(gpointer data).

This had been intentionally removed in the crash fix bug 98055.

While working on XHR2 timeout support, I am hitting this crash again, let's remove it.
Comment 1 Dominik Röttsches (drott) 2012-10-15 05:33:28 PDT
Created attachment 168688 [details]
Patch
Comment 2 Dominik Röttsches (drott) 2012-10-15 07:47:13 PDT
Comment on attachment 168688 [details]
Patch

Clearing flags on attachment: 168688

Committed r131301: <http://trac.webkit.org/changeset/131301>
Comment 3 Dominik Röttsches (drott) 2012-10-15 07:47:21 PDT
All reviewed patches have been landed.  Closing bug.