Bug 99303 - [Qt][WK2] Buildfix for newer Qt5
Summary: [Qt][WK2] Buildfix for newer Qt5
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 420+
Hardware: All All
: P1 Blocker
Assignee: Csaba Osztrogonác
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2012-10-15 02:27 PDT by Csaba Osztrogonác
Modified: 2012-10-15 03:37 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.42 KB, patch)
2012-10-15 02:29 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2012-10-15 02:27:42 PDT
d4d81fe68aa7d2b2a89ae5e049dd630e0da77651 in qtbase 
( https://codereview.qt-project.org/#change,35807 )
removed handleSynchronous* functions, so we need
a buildfix for WebKit trunk with updating Qt5 hash.

Patch is coming soon.
Comment 1 Csaba Osztrogonác 2012-10-15 02:29:22 PDT
Created attachment 168655 [details]
Patch
Comment 2 Csaba Osztrogonác 2012-10-15 02:30:33 PDT
Comment on attachment 168655 [details]
Patch

cq-, because we should land it with updating Qt5 on the bots.
Comment 3 Simon Hausmann 2012-10-15 03:25:39 PDT
(In reply to comment #2)
> (From update of attachment 168655 [details])
> cq-, because we should land it with updating Qt5 on the bots.

I suppose we could also land it earlier? The EWS indicates that it should be a source compatible change.
Comment 4 Csaba Osztrogonác 2012-10-15 03:29:07 PDT
Comment on attachment 168655 [details]
Patch

Cool, let's land it now.
Comment 5 Csaba Osztrogonác 2012-10-15 03:37:25 PDT
Comment on attachment 168655 [details]
Patch

Clearing flags on attachment: 168655

Committed r131294: <http://trac.webkit.org/changeset/131294>
Comment 6 Csaba Osztrogonác 2012-10-15 03:37:29 PDT
All reviewed patches have been landed.  Closing bug.