Bug 99302 - [BlackBerry] replace BlackBerry::Platform::log() with BBLOG()
Summary: [BlackBerry] replace BlackBerry::Platform::log() with BBLOG()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Dong
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-15 01:42 PDT by Jonathan Dong
Modified: 2012-10-16 11:04 PDT (History)
11 users (show)

See Also:

Attachments
Patch (42.01 KB, patch)
2012-10-15 01:52 PDT, Jonathan Dong 		no flags Details | Formatted Diff | Diff
Patch (1.69 KB, patch)
2012-10-16 08:29 PDT, Rob Buis 		yong.li.webkit: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Dong 2012-10-15 01:42:25 PDT 
RIM PR: 210884

BBLOG() is natively defined as a no-op in release mode, so replace BlackBerry::Platform::log() with BBLOG() will save a function call in release mode.
Comment 1 Jonathan Dong 2012-10-15 01:52:47 PDT 
Created attachment 168649 [details]
Patch
Comment 2 Rob Buis 2012-10-15 06:44:40 PDT 
Comment on attachment 168649 [details]
Patch

LGTM.
Comment 3 Charles Wei 2012-10-15 07:42:29 PDT 
Comment on attachment 168649 [details]
Patch

Commit
Comment 4 WebKit Review Bot 2012-10-15 12:35:22 PDT 
Comment on attachment 168649 [details]
Patch

Clearing flags on attachment: 168649

Committed r131335: <http://trac.webkit.org/changeset/131335>
Comment 5 WebKit Review Bot 2012-10-15 12:35:26 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Rob Buis 2012-10-16 08:29:41 PDT 
Reopening to attach new patch.
Comment 7 Rob Buis 2012-10-16 08:29:44 PDT 
Created attachment 168953 [details]
Patch
Comment 8 Yong Li 2012-10-16 10:37:23 PDT 
Comment on attachment 168953 [details]
Patch

!NDEBUG should be !defined(NDEBUG)
Comment 9 Rob Buis 2012-10-16 11:04:16 PDT 
Committed r131473: <http://trac.webkit.org/changeset/131473>