Bug 99300 - Web Inspector: Hide useless controls in remote-debugging mode.
Summary: Web Inspector: Hide useless controls in remote-debugging mode.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: eustas.bug
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-15 01:22 PDT by eustas.bug
Modified: 2012-10-15 13:03 PDT (History)
13 users (show)

See Also:

Attachments
Patch (1.75 KB, patch)
2012-10-15 01:24 PDT, eustas.bug 		no flags Details | Formatted Diff | Diff
Patch (1.75 KB, patch)
2012-10-15 04:34 PDT, eustas.bug 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description eustas.bug 2012-10-15 01:22:30 PDT 
"Close inspector" and "change docking mode" buttons seem to be rather useless in remote debugging mode.
Comment 1 eustas.bug 2012-10-15 01:24:33 PDT 
Created attachment 168645 [details]
Patch
Comment 2 Andrey Kosyakov 2012-10-15 02:24:26 PDT 
Comment on attachment 168645 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168645&action=review

> Source/WebCore/inspector/front-end/inspector.css:762
>  body.port-qt #dock-status-bar-item {

Could you please also fix this as a drive by? Perhaps, just merge them?
Comment 3 eustas.bug 2012-10-15 04:29:50 PDT 
Comment on attachment 168645 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168645&action=review

>> Source/WebCore/inspector/front-end/inspector.css:762
>>  body.port-qt #dock-status-bar-item {
> 
> Could you please also fix this as a drive by? Perhaps, just merge them?

No problem.
Comment 4 eustas.bug 2012-10-15 04:34:25 PDT 
Created attachment 168676 [details]
Patch
Comment 5 Andrey Kosyakov 2012-10-15 04:40:29 PDT 
Comment on attachment 168676 [details]
Patch

LGTM
Comment 6 WebKit Review Bot 2012-10-15 13:03:39 PDT 
Comment on attachment 168676 [details]
Patch

Clearing flags on attachment: 168676

Committed r131342: <http://trac.webkit.org/changeset/131342>
Comment 7 WebKit Review Bot 2012-10-15 13:03:44 PDT 
All reviewed patches have been landed.  Closing bug.