Make UserScript and UserStyleSheet value objects that are copyable
Created attachment 168590 [details] Patch
Attachment 168590 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/page/PageGroup.cpp:265: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/page/PageGroup.cpp:280: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/page/UserStyleSheet.h:40: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:299: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/page/UserScript.h:40: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/page/PageGroup.h:86: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/page/PageGroup.h:89: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 7 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 168590 [details] Patch Attachment 168590 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/14293537
Created attachment 168592 [details] Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=168590&action=review r=me assuming you've just managed to fix the build issues. > Source/WebCore/ChangeLog:34 > + (WebCore::PageGroup::addUserScriptToWorld): > + (WebCore::PageGroup::addUserStyleSheetToWorld): > + * page/PageGroup.h: > + (PageGroup): > + * page/UserContentURLPattern.cpp: > + (WebCore::UserContentURLPattern::matchesPatterns): > + * page/UserContentURLPattern.h: > + (UserContentURLPattern): > + Update to not assume whitelist and blacklist are in Vector<String>*. > + > + * page/UserScript.h: > + (UserScript): > + (WebCore::UserScript::UserScript): > + (WebCore::UserScript::whitelist): > + (WebCore::UserScript::blacklist): > + * page/UserStyleSheet.h: > + (UserStyleSheet): > + (WebCore::UserStyleSheet::UserStyleSheet): > + (WebCore::UserStyleSheet::whitelist): > + (WebCore::UserStyleSheet::blacklist): Dan would not be happy about this lack of per-function comments. > Source/WebCore/page/UserContentURLPattern.cpp:39 > + for (unsigned i = 0; i < whitelist.size(); ++i) { I know you're not introducing this, but should we save size aside instead of computing it every time? >> Source/WebCore/page/UserScript.h:40 >> + const Vector<String>& whitelist, const Vector<String>& blacklist, > > Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Stylebot is right, why are these all lined up? That is unusual for WebCore.
Attachment 168592 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/page/PageGroup.cpp:265: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/page/PageGroup.cpp:280: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/page/UserStyleSheet.h:40: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:299: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/page/UserScript.h:40: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/page/PageGroup.h:86: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/page/PageGroup.h:89: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 7 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r131275: <http://trac.webkit.org/changeset/131275>