Bug 99270 - REGRESSION(126886): Fat binary builds don't know how to handle architecture variants to which the LLInt is agnostic
Summary: REGRESSION(126886): Fat binary builds don't know how to handle architecture v...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on: 90098
Blocks:
  Show dependency tree / graph
 
Reported: 2012-10-14 13:05 PDT by Filip Pizlo
Modified: 2012-10-14 19:33 PDT (History)
7 users (show)

See Also:

Attachments
the patch (1.90 KB, patch)
2012-10-14 13:11 PDT, Filip Pizlo 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-10-14 13:05:34 PDT 
This comes up with ARMv7s, where the C++ toolchain handles it as a separate architecture and may end up compiling the code in a substantially different way, while the LLInt doesn't care.  The fix for https://bugs.webkit.org/show_bug.cgi?id=90098 causes the offlineasm's knowledge of ARMv7s to be dropped, since it assumes that if the offsets are the same then the configuration is the same.  That's just plain wrong, since it's the configuration index (identifying the combination of settings flags) that should be uniq'd, not the offsets.
Comment 1 Filip Pizlo 2012-10-14 13:11:05 PDT 
Created attachment 168588 [details]
the patch
Comment 2 Geoffrey Garen 2012-10-14 19:08:08 PDT 
Comment on attachment 168588 [details]
the patch

r=me
Comment 3 Filip Pizlo 2012-10-14 19:33:25 PDT 
Landed in http://trac.webkit.org/changeset/131287