Bug 99269 - DFG should handle polymorphic array modes by eagerly transforming arrays into the most general applicable form
Summary: DFG should handle polymorphic array modes by eagerly transforming arrays into...
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
Depends on:
Blocks: 98606 99260
  Show dependency treegraph
Reported: 2012-10-14 12:41 PDT by Filip Pizlo
Modified: 2012-10-14 20:18 PDT (History)
6 users (show)

See Also:

work in progress (24.94 KB, patch)
2012-10-14 17:26 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff
the patch (34.57 KB, patch)
2012-10-14 18:18 PDT, Filip Pizlo
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-10-14 12:41:49 PDT
If we see a use of both Contiguous and ArrayStorage, we should just convert to ArrayStorage instead of handling both.

Similarly, in the future when we have Int32 and Double arrays, and we see a use of both Int32 and Double, we should just convert to Double instead of handling both.

This should be a speed-up and a huge simplification, since the current "polymorphic" modes require a lot of code.
Comment 1 Filip Pizlo 2012-10-14 14:03:20 PDT

*** This bug has been marked as a duplicate of bug 99260 ***
Comment 2 Filip Pizlo 2012-10-14 16:57:19 PDT
On second thought, I'm going to do this separately from https://bugs.webkit.org/show_bug.cgi?id=99260.
Comment 3 Filip Pizlo 2012-10-14 17:26:46 PDT
Created attachment 168601 [details]
work in progress
Comment 4 Filip Pizlo 2012-10-14 18:18:47 PDT
Created attachment 168603 [details]
the patch
Comment 5 Geoffrey Garen 2012-10-14 19:09:39 PDT
Comment on attachment 168603 [details]
the patch

Comment 6 Filip Pizlo 2012-10-14 20:18:52 PDT
Landed in http://trac.webkit.org/changeset/131289