Bug 99265 - [EFL][WK2] Display page favicons in MiniBrowser
Summary: [EFL][WK2] Display page favicons in MiniBrowser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 99087
Blocks:
  Show dependency tree / graph
 
Reported: 2012-10-14 00:33 PDT by Chris Dumez
Modified: 2012-10-15 23:31 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.75 KB, patch)
2012-10-14 06:22 PDT, Chris Dumez 		gyuyoung.kim: commit-queue-
Details | Formatted Diff | Diff
Patch (3.75 KB, patch)
2012-10-15 13:27 PDT, Chris Dumez 		gyuyoung.kim: review+
Details | Formatted Diff | Diff
Patch for landing (3.81 KB, patch)
2012-10-15 22:43 PDT, Chris Dumez 		cdumez: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (3.81 KB, patch)
2012-10-15 23:10 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-10-14 00:33:13 PDT 
We should use the new Favicon API from Bug 99087 and display page favicons in MiniBrowser.
Comment 1 Chris Dumez 2012-10-14 06:22:00 PDT 
Created attachment 168582 [details]
Patch
Comment 2 Gyuyoung Kim 2012-10-14 06:26:57 PDT 
Comment on attachment 168582 [details]
Patch

Attachment 168582 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14311012
Comment 3 Chris Dumez 2012-10-15 13:27:27 PDT 
Created attachment 168769 [details]
Patch
Comment 4 Gyuyoung Kim 2012-10-15 18:12:28 PDT 
Comment on attachment 168769 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168769&action=review

> Tools/MiniBrowser/efl/main.c:345
> +        evas_object_ref(icon);

You remove icon object without doing unref at 334 line. So, do you need to increase ref count here ?
Comment 5 Chris Dumez 2012-10-15 21:55:16 PDT 
Comment on attachment 168769 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168769&action=review

> Tools/MiniBrowser/efl/main.c:335
> +        evas_object_del(old_icon);

Right, I probably need to unref() here as well.

>> Tools/MiniBrowser/efl/main.c:345
>> +        evas_object_ref(icon);
> 
> You remove icon object without doing unref at 334 line. So, do you need to increase ref count here ?

Yes, the caller will unref() the icon after the callback is called so the callback should ref() it if it wishes to use / keep it.
Comment 6 Chris Dumez 2012-10-15 22:43:39 PDT 
Created attachment 168855 [details]
Patch for landing

Could someone please cq+ ?
Comment 7 Gyuyoung Kim 2012-10-15 22:59:02 PDT 
Comment on attachment 168855 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=168855&action=review

> Tools/MiniBrowser/efl/main.c:335
> +        evas_object_unref(icon);

Could you explain why you do unref *icon* instead of *old_icon* ?
Comment 8 Chris Dumez 2012-10-15 23:04:16 PDT 
Comment on attachment 168855 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=168855&action=review

>> Tools/MiniBrowser/efl/main.c:335
>> +        evas_object_unref(icon);
> 
> Could you explain why you do unref *icon* instead of *old_icon* ?

because I did not properly wake up yet :) Thanks for catching this.
Comment 9 Chris Dumez 2012-10-15 23:10:35 PDT 
Created attachment 168864 [details]
Patch for landing

Fixed wrong unref (Thanks Gyuyoung).
Comment 10 WebKit Review Bot 2012-10-15 23:31:07 PDT 
Comment on attachment 168864 [details]
Patch for landing

Clearing flags on attachment: 168864

Committed r131416: <http://trac.webkit.org/changeset/131416>
Comment 11 WebKit Review Bot 2012-10-15 23:31:11 PDT 
All reviewed patches have been landed.  Closing bug.