Bug 99256 – Use class extension rather than a void* member for new Objective-C WebProcessPlugIn SPI

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

Use class extension rather than a void* member for new Objective-C WebProcessPlugIn SPI

[Sam Weinig]

Created attachment 168571 [details]
Patch

[WebKit Review Bot]

Attachment 168571 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerInternal.h:30:  Extra space before ( in function call  [whitespace/parens] [4]
Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerPrivate.h:30:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 168571 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168571&action=review

> Source/WebKit2/ChangeLog:8
> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).

:\

[Sam Weinig]

(In reply to comment #3)
> (From update of attachment 168571 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=168571&action=review
> 
> > Source/WebKit2/ChangeLog:8
> > +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).
> 
> :\

:(

[Sam Weinig]

Committed r131264: <http://trac.webkit.org/changeset/131264>