Bug 99256 - Use class extension rather than a void* member for new Objective-C WebProcessPlugIn SPI
Summary: Use class extension rather than a void* member for new Objective-C WebProcess...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-13 19:09 PDT by Sam Weinig
Modified: 2012-10-13 19:21 PDT (History)
1 user (show)

See Also:

Attachments
Patch (12.81 KB, patch)
2012-10-13 19:14 PDT, Sam Weinig 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2012-10-13 19:09:13 PDT 
Use class extension rather than a void* member for new Objective-C WebProcessPlugIn SPI
Comment 1 Sam Weinig 2012-10-13 19:14:36 PDT 
Created attachment 168571 [details]
Patch
Comment 2 WebKit Review Bot 2012-10-13 19:16:41 PDT 
Attachment 168571 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerInternal.h:30:  Extra space before ( in function call  [whitespace/parens] [4]
Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerPrivate.h:30:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 mitz 2012-10-13 19:17:37 PDT 
Comment on attachment 168571 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168571&action=review

> Source/WebKit2/ChangeLog:8
> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).

:\
Comment 4 Sam Weinig 2012-10-13 19:20:35 PDT 
(In reply to comment #3)
> (From update of attachment 168571 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=168571&action=review
> 
> > Source/WebKit2/ChangeLog:8
> > +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).
> 
> :\

:(
Comment 5 Sam Weinig 2012-10-13 19:21:30 PDT 
Committed r131264: <http://trac.webkit.org/changeset/131264>