Bug 99235 - Add warning for unrenderable textures
Summary: Add warning for unrenderable textures
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Gregg Tavares
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-12 22:44 PDT by Gregg Tavares
Modified: 2012-10-13 10:55 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.38 KB, patch)
2012-10-12 22:45 PDT, Gregg Tavares 		no flags Details | Formatted Diff | Diff
Patch (4.39 KB, patch)
2012-10-13 10:08 PDT, Gregg Tavares 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gregg Tavares 2012-10-12 22:44:05 PDT 
Add warning for unrenderable textures
Comment 1 Gregg Tavares 2012-10-12 22:45:46 PDT 
Created attachment 168542 [details]
Patch
Comment 2 WebKit Review Bot 2012-10-12 22:49:03 PDT 
Attachment 168542 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Gregg Tavares 2012-10-13 10:08:52 PDT 
Created attachment 168557 [details]
Patch
Comment 4 Kenneth Russell 2012-10-13 10:18:08 PDT 
Comment on attachment 168557 [details]
Patch

Helpful. r=me
Comment 5 WebKit Review Bot 2012-10-13 10:55:36 PDT 
Comment on attachment 168557 [details]
Patch

Clearing flags on attachment: 168557

Committed r131261: <http://trac.webkit.org/changeset/131261>
Comment 6 WebKit Review Bot 2012-10-13 10:55:39 PDT 
All reviewed patches have been landed.  Closing bug.