RESOLVED LATER99233
Update the set-href-attribute-port test 
https://bugs.webkit.org/show_bug.cgi?id=99233
Summary Update the set-href-attribute-port test
Benjamin Poulain
Reported 2012-10-12 19:17:46 PDT
It's the test that turn out to be bad, not the parser.
Attachments
Patch (3.52 KB, patch)
2012-10-12 19:21 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (3.57 KB, patch)
2012-10-12 20:52 PDT, Benjamin Poulain 		benjamin: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2012-10-12 19:21:02 PDT
Created attachment 168531 [details] Patch
Build Bot
Comment 2 2012-10-12 20:43:51 PDT
Comment on attachment 168531 [details] Patch Attachment 168531 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14292115 New failing tests: fast/dom/HTMLAnchorElement/set-href-attribute-port.html
Benjamin Poulain
Comment 3 2012-10-12 20:52:06 PDT
Created attachment 168534 [details] Patch
Benjamin Poulain
Comment 4 2012-10-12 23:16:07 PDT
Comment on attachment 168534 [details] Patch Never mind. According to http://dev.w3.org/html5/spec/single-page.html#dom-uda-protocol, KURL is actually correct. All the other implementations are incorrect.
Ian 'Hixie' Hickson
Comment 5 2012-10-15 11:37:31 PDT
See also: http://url.spec.whatwg.org/ (ping Anne)
Benjamin Poulain
Comment 6 2012-10-15 12:24:16 PDT
(In reply to comment #5) > See also: http://url.spec.whatwg.org/ > (ping Anne) Great! Please also consider the case of HTMLAnchorElement which is quite a mess in practice.
Anne van Kesteren
Comment 7 2012-10-15 23:56:46 PDT
Setting port should only work for URLs of which we know the scheme to support that: http://url.spec.whatwg.org/#hierarchical-scheme What url.spec.whatwg.org calls URLUtils will eventually be how HTMLAnchorElement is defined. Just need to polish the specification a bit more and change a few terms around.
Benjamin Poulain
Comment 8 2012-10-16 11:35:08 PDT
(In reply to comment #7) > Setting port should only work for URLs of which we know the scheme to support that: http://url.spec.whatwg.org/#hierarchical-scheme > > What url.spec.whatwg.org calls URLUtils will eventually be how HTMLAnchorElement is defined. Just need to polish the specification a bit more and change a few terms around. This: http://url.spec.whatwg.org/#hierarchical-scheme is inconsistent with http://dev.w3.org/html5/spec/single-page.html#authority-based-url It looks to me that http://url.spec.whatwg.org/#hierarchical-scheme just follows the principle of GoogleURL's IsStandardScheme() but with file: and filesystem: missing. (http://code.google.com/p/google-url/source/browse/trunk/src/url_util.cc) Neither definition closely follows reality. What is the plan there, get rid of the URL part of the HTML5 spec?
Anne van Kesteren
Comment 9 2012-10-16 12:36:32 PDT
Yes, HTML URL handling will go away in favor of the URL Standard. file URLs do not have a port either typically, but are usually hierarchical, indeed...
Benjamin Poulain
Comment 10 2012-10-23 14:14:35 PDT
I'll fix that later as the new URL spec improve.
Note You need to log in before you can comment on or make changes to this bug.