Bug 99225 - StringBuilder::append(StringBuilder&) doesn't take into account the bit size of the argument string
Summary: StringBuilder::append(StringBuilder&) doesn't take into account the bit size ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-12 17:56 PDT by Michael Saboff
Modified: 2012-10-12 22:33 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.19 KB, patch)
2012-10-12 18:06 PDT, Michael Saboff
benjamin: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Fix for test failures (1.21 KB, patch)
2012-10-12 22:23 PDT, Michael Saboff
benjamin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2012-10-12 17:56:43 PDT
StringBuilder::append(StringBuilder& other) always uses other.characters() to access the characters to append.  This should be changed to use characters8() or characters16() as appropriate.
Comment 1 Michael Saboff 2012-10-12 18:06:50 PDT
Created attachment 168523 [details]
Patch
Comment 2 Build Bot 2012-10-12 21:13:10 PDT
Comment on attachment 168523 [details]
Patch

Attachment 168523 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14292122

New failing tests:
fast/css/transform-inline-style.html
editing/execCommand/5458246.html
fast/css/remove-shorthand.html
fast/dom/HTMLMeterElement/meter-element-with-child-crash.html
editing/execCommand/create-list-with-hr.html
editing/pasteboard/input-field-1.html
editing/inserting/insert-images-in-pre-x-crash.html
fast/backgrounds/repeat/parsing-background-repeat.html
editing/pasteboard/4806874.html
fast/css/transform-inline-style-remove.html
editing/pasteboard/paste-line-endings-001.html
fast/backgrounds/background-shorthand-with-backgroundSize-style.html
fast/css/background-position-serialize.html
editing/execCommand/insert-ordered-list.html
editing/execCommand/infinite-recursion-computeRectForRepaint.html
fast/dom/background-shorthand-csstext.html
fast/css/shorthand-mismatched-list-crash.html
Comment 3 Michael Saboff 2012-10-12 22:23:54 PDT
Created attachment 168541 [details]
Fix for test failures

Added missing "else".
Comment 4 Michael Saboff 2012-10-12 22:30:05 PDT
Committed r131250: <http://trac.webkit.org/changeset/131250>
Comment 5 Benjamin Poulain 2012-10-12 22:33:50 PDT
Comment on attachment 168541 [details]
Fix for test failures

Silly me. I checked characters8() and characters16(), and did not pay much attention to the actual code...