Bug 99223 - AtomicString::HashAndUTF8CharactersTranslator::equal() doesn't optimally handle 8 bit strings
Summary: AtomicString::HashAndUTF8CharactersTranslator::equal() doesn't optimally hand...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-12 17:56 PDT by Michael Saboff
Modified: 2012-10-17 15:08 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.17 KB, patch)
2012-10-12 18:05 PDT, Michael Saboff 		no flags Details | Formatted Diff | Diff
Updated Patch (2.04 KB, patch)
2012-10-12 18:11 PDT, Michael Saboff 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2012-10-12 17:56:36 PDT 
HashAndUTF8CharactersTranslator::equal() uses StringImpl::characters() on subject string to access the characters to compare, possibly up converting an 8 bit string.
Comment 1 Michael Saboff 2012-10-12 18:05:57 PDT 
Created attachment 168520 [details]
Patch
Comment 2 Michael Saboff 2012-10-12 18:11:32 PDT 
Created attachment 168524 [details]
Updated Patch

Cleaned up white space error in original patch.
Comment 3 Geoffrey Garen 2012-10-17 14:51:27 PDT 
Comment on attachment 168524 [details]
Updated Patch

r=me
Comment 4 WebKit Review Bot 2012-10-17 15:08:27 PDT 
Comment on attachment 168524 [details]
Updated Patch

Clearing flags on attachment: 168524

Committed r131652: <http://trac.webkit.org/changeset/131652>
Comment 5 WebKit Review Bot 2012-10-17 15:08:30 PDT 
All reviewed patches have been landed.  Closing bug.