Multiple web processes should share shared workers.
Created attachment 168515 [details] proposed patch
Comment on attachment 168515 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=168515&action=review I'd love to see this share more code, but looks good. > Source/WebKit2/Shared/SharedWorkerProcessCreationParameters.h:33 > +#if PLATFORM(MAC) > +#include "MachPort.h" > +#endif This does not seem to be used. > Source/WebKit2/SharedWorkerProcess/mac/SharedWorkerProcessMac.mm:71 > +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1070 > + initializeSandbox(); > +#endif This is not an ideal place to initialize the sandbox. Instead, it should initialized directly from main as we do for the WebProcess.
Attachment 168515 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/UIProcess/SharedWorkers/SharedWorkerProcessProxy.cpp:94: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/UIProcess/SharedWorkers/SharedWorkerProcessManager.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebKit2/Shared/SharedWorkerProcessCreationParameters.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebKit2/UIProcess/SharedWorkers/SharedWorkerProcessProxy.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebKit2/UIProcess/SharedWorkers/SharedWorkerProcessProxy.h:74: The parameter name "parameters" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit2/SharedWorkerProcess/SharedWorkerProcess.h:41: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Source/WebKit2/SharedWorkerProcess/SharedWorkerProcess.h:48: The parameter name "webProcessConnection" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 7 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 168515 [details] proposed patch Attachment 168515 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14293078
Comment on attachment 168515 [details] proposed patch Attachment 168515 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14299062
Comment on attachment 168515 [details] proposed patch Attachment 168515 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14286083
Comment on attachment 168515 [details] proposed patch Attachment 168515 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14290097
Comment on attachment 168515 [details] proposed patch Attachment 168515 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/14334004
Created attachment 168561 [details] with build fix
Attachment 168561 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/UIProcess/SharedWorkers/SharedWorkerProcessProxy.cpp:94: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/UIProcess/SharedWorkers/SharedWorkerProcessManager.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebKit2/Shared/SharedWorkerProcessCreationParameters.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebKit2/UIProcess/SharedWorkers/SharedWorkerProcessProxy.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebKit2/UIProcess/SharedWorkers/SharedWorkerProcessProxy.h:74: The parameter name "parameters" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit2/SharedWorkerProcess/SharedWorkerProcess.h:41: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Source/WebKit2/SharedWorkerProcess/SharedWorkerProcess.h:48: The parameter name "webProcessConnection" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 7 in 29 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 168561 [details] with build fix Attachment 168561 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14291289
The Windows build failure doesn't look like something that can be resolved blindly, will have to land and work on fixing the build afterwards. Committed <http://trac.webkit.org/changeset/131308>.