Bug 99215 - WebAudioBus needs support for resizing bus to a smaller size
Summary: WebAudioBus needs support for resizing bus to a smaller size
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Rogers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-12 15:52 PDT by Chris Rogers
Modified: 2012-10-13 11:21 PDT (History)
9 users (show)

See Also:

Attachments
Patch (6.50 KB, patch)
2012-10-12 15:57 PDT, Chris Rogers 		no flags Details | Formatted Diff | Diff
Patch (6.58 KB, patch)
2012-10-12 16:11 PDT, Chris Rogers 		no flags Details | Formatted Diff | Diff
Patch (6.60 KB, patch)
2012-10-12 16:14 PDT, Chris Rogers 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2012-10-12 15:52:03 PDT 
WebAudioBus needs support for resizing bus to a smaller size
Comment 1 Chris Rogers 2012-10-12 15:57:53 PDT 
Created attachment 168503 [details]
Patch
Comment 2 WebKit Review Bot 2012-10-12 16:00:46 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Kenneth Russell 2012-10-12 16:05:50 PDT 
Comment on attachment 168503 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168503&action=review

> Source/Platform/chromium/public/WebAudioBus.h:54
> +    WEBKIT_EXPORT void resize(size_t newLength);

Others responsible for the design of the WebKit API should comment on this, but if this restriction is always going to apply, then this method should be called something more descriptive, like "resizeSmaller".
Comment 4 Chris Rogers 2012-10-12 16:11:10 PDT 
Created attachment 168505 [details]
Patch
Comment 5 Kenneth Russell 2012-10-12 16:13:48 PDT 
Comment on attachment 168505 [details]
Patch

Thanks. This looks good to me but please regenerate the ChangeLogs after the method renaming.
Comment 6 Chris Rogers 2012-10-12 16:14:37 PDT 
Created attachment 168507 [details]
Patch
Comment 7 Chris Rogers 2012-10-12 16:15:56 PDT 
(In reply to comment #5)
> (From update of attachment 168505 [details])
> Thanks. This looks good to me but please regenerate the ChangeLogs after the method renaming.

Thanks, fixed to resizeSmaller() and also re-generated ChangeLogs
Comment 8 Kenneth Russell 2012-10-12 16:36:56 PDT 
Comment on attachment 168507 [details]
Patch

This LGTM. One of the owners of the WebKit API should review it.
Comment 9 WebKit Review Bot 2012-10-13 11:21:51 PDT 
Comment on attachment 168507 [details]
Patch

Clearing flags on attachment: 168507

Committed r131262: <http://trac.webkit.org/changeset/131262>
Comment 10 WebKit Review Bot 2012-10-13 11:21:56 PDT 
All reviewed patches have been landed.  Closing bug.