RESOLVED FIXED 99214
Teach GeneratorGObject about [ImplementedAs] extended attribute in functions 
https://bugs.webkit.org/show_bug.cgi?id=99214
Summary Teach GeneratorGObject about [ImplementedAs] extended attribute in functions
Pablo Flouret
Reported 2012-10-12 15:50:50 PDT
Looks like, coincidentally, all functions declaring [ImplementedAs] were skipped so this never manifested itself, until bug 99116 came around.
Attachments
Patch (4.12 KB, patch)
2012-10-12 15:56 PDT, Pablo Flouret 		haraken: review+
haraken: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (4.73 KB, patch)
2012-10-12 16:40 PDT, Pablo Flouret 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pablo Flouret
Comment 1 2012-10-12 15:56:16 PDT
Created attachment 168502 [details] Patch
Kentaro Hara
Comment 2 2012-10-12 16:33:05 PDT
Comment on attachment 168502 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168502&action=review > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:979 > + my $functionImplementationName = $function->signature->extendedAttributes->{"ImplementedAs"} || $function->signature->name; Nit: You can use $functionSigName instead of $function->signature->name. Or you can remove $functionSigName since it is not used so much.
Pablo Flouret
Comment 3 2012-10-12 16:40:08 PDT
Created attachment 168511 [details] Patch for landing
WebKit Review Bot
Comment 4 2012-10-12 17:56:49 PDT
Comment on attachment 168511 [details] Patch for landing Clearing flags on attachment: 168511 Committed r131242: <http://trac.webkit.org/changeset/131242>
Note You need to log in before you can comment on or make changes to this bug.