Bug 99214 - Teach GeneratorGObject about [ImplementedAs] extended attribute in functions
Summary: Teach GeneratorGObject about [ImplementedAs] extended attribute in functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Pablo Flouret
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-12 15:50 PDT by Pablo Flouret
Modified: 2012-10-15 21:27 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.12 KB, patch)
2012-10-12 15:56 PDT, Pablo Flouret 		haraken: review+
haraken: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (4.73 KB, patch)
2012-10-12 16:40 PDT, Pablo Flouret 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pablo Flouret 2012-10-12 15:50:50 PDT 
Looks like, coincidentally, all functions declaring [ImplementedAs] were skipped so this never manifested itself, until bug 99116 came around.
Comment 1 Pablo Flouret 2012-10-12 15:56:16 PDT 
Created attachment 168502 [details]
Patch
Comment 2 Kentaro Hara 2012-10-12 16:33:05 PDT 
Comment on attachment 168502 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168502&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:979
> +    my $functionImplementationName = $function->signature->extendedAttributes->{"ImplementedAs"} || $function->signature->name;

Nit: You can use $functionSigName instead of $function->signature->name. Or you can remove $functionSigName since it is not used so much.
Comment 3 Pablo Flouret 2012-10-12 16:40:08 PDT 
Created attachment 168511 [details]
Patch for landing
Comment 4 WebKit Review Bot 2012-10-12 17:56:49 PDT 
Comment on attachment 168511 [details]
Patch for landing

Clearing flags on attachment: 168511

Committed r131242: <http://trac.webkit.org/changeset/131242>